Reland of "Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID"

test/cctest/parsing/test-parse-decision.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Test specific cases of the lazy/eager-parse decision.
 //
 // Note that presently most unit tests for parsing are found in
 // cctest/test-parsing.cc.
 
 #include <unordered_map>
@@ skipping 12 matching lines @@
 
 // Record the 'compiled' state of all top level functions.
 void GetTopLevelFunctionInfo(
     v8::Local<v8::Script> script,
     std::unordered_map<std::string, bool>* is_compiled) {
   // Get the v8::internal::Script object from the API v8::Script.
   // The API object 'wraps' the compiled top-level function, not the i::Script.
   Handle<JSFunction> toplevel_fn = v8::Utils::OpenHandle(*script);
   Handle<Script> i_script =
       handle(Script::cast(toplevel_fn->shared()->script()));
+  SharedFunctionInfo::ScriptIterator iterator(i_script);
 
-  WeakFixedArray::Iterator iter(i_script->shared_function_infos());
-  while (SharedFunctionInfo* shared = iter.Next<SharedFunctionInfo>()) {
+  while (SharedFunctionInfo* shared = iterator.Next()) {
     std::unique_ptr<char[]> name = String::cast(shared->name())->ToCString();
     is_compiled->insert(std::make_pair(name.get(), shared->is_compiled()));
   }
 }
 
 }  // anonymous namespace
 
 TEST(GetTopLevelFunctionInfo) {
   if (!FLAG_lazy) return;
 
@@ skipping 51 matching lines @@
   LocalContext env;
 
   const char src[] = "!function a(){}(),function b(){}(),function c(){}();";
   std::unordered_map<std::string, bool> is_compiled;
   GetTopLevelFunctionInfo(v8_compile(src), &is_compiled);
 
   DCHECK(is_compiled["a"]);
   DCHECK(is_compiled["b"]);
   DCHECK(is_compiled["c"]);
 }