Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/ui/omnibox/chrome_omnibox_client.cc

Issue 2576833002: Make some updates to extension iconography. (Closed)
Patch Set: add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/chrome_omnibox_client.cc
diff --git a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
index faa180d86be6d066dbe5521146b5348ac27c12cb..3e12199b9ce6e01a39cd809637a45215c28636ef 100644
--- a/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
+++ b/chrome/browser/ui/omnibox/chrome_omnibox_client.cc
@@ -48,6 +48,7 @@
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/web_contents.h"
#include "extensions/common/constants.h"
+#include "third_party/skia/include/core/SkBitmap.h"
Peter Kasting 2016/12/15 07:54:26 Nit: Is this an IWYU change?
Evan Stade 2016/12/15 23:49:02 more or less. It was relying on a transitive inclu
#include "ui/base/window_open_disposition.h"
#include "url/gurl.h"
@@ -214,8 +215,8 @@ gfx::Image ChromeOmniboxClient::GetIconIfExtensionMatch(
const TemplateURL* template_url = match.GetTemplateURL(service, false);
if (template_url &&
(template_url->type() == TemplateURL::OMNIBOX_API_EXTENSION)) {
- return extensions::OmniboxAPI::Get(profile_)
- ->GetOmniboxPopupIcon(template_url->GetExtensionId());
+ return extensions::OmniboxAPI::Get(profile_)->GetOmniboxIcon(
+ template_url->GetExtensionId());
}
return gfx::Image();
}

Powered by Google App Engine
This is Rietveld 408576698