Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: chrome/browser/extensions/menu_manager.h

Issue 2576833002: Make some updates to extension iconography. (Closed)
Patch Set: add test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.h
diff --git a/chrome/browser/extensions/menu_manager.h b/chrome/browser/extensions/menu_manager.h
index 3a97c5852e11fadce8ff57a80d8a9664f93e294b..a5af7b9ee713cbd24f8a4a02285aeb52a42d4625 100644
--- a/chrome/browser/extensions/menu_manager.h
+++ b/chrome/browser/extensions/menu_manager.h
@@ -28,8 +28,6 @@
#include "extensions/browser/extension_registry_observer.h"
#include "extensions/common/url_pattern_set.h"
-class SkBitmap;
-
namespace content {
class BrowserContext;
class RenderFrameHost;
@@ -349,7 +347,7 @@ class MenuManager : public content::NotificationObserver,
// This returns a bitmap of width/height kFaviconSize, loaded either from an
Devlin 2016/12/15 17:14:41 nit: update (no longer returns a bitmap)
Evan Stade 2016/12/15 23:49:02 Done.
// entry specified in the extension's 'icon' section of the manifest, or a
// default extension icon.
- const SkBitmap& GetIconForExtension(const std::string& extension_id);
+ gfx::Image GetIconForExtension(const std::string& extension_id);
Devlin 2016/12/15 17:14:41 nit: iwyu
Evan Stade 2016/12/15 23:49:02 Done.
// content::NotificationObserver implementation.
void Observe(int type,

Powered by Google App Engine
This is Rietveld 408576698