chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc - Issue 2576833002: Make some updates to extension iconography.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Issue 2576833002: Make some updates to extension iconography. (Closed)

Patch Set: add test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/omnibox/chrome_omnibox_client.cc ('K') | « chrome/browser/ui/omnibox/chrome_omnibox_client.cc ('k') | chrome/browser/ui/webui/app_launcher_page_ui.cc » ('j') | chrome/test/data/extensions/context_menus/icons/sample.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

index 78ad7f9167cd134209757d61bea9a04dd1df2316..0ac3d9395ca43204acb70a7187590c9c9f47ed6b 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

@@ -79,9 +79,7 @@ ExtensionInstallDialogViewTestBase::CreatePrompt() {

std::unique_ptr<ExtensionIconManager> icon_manager(

new ExtensionIconManager());

- const SkBitmap icon_bitmap = icon_manager->GetIcon(extension_->id());

- gfx::Image icon = gfx::Image::CreateFrom1xBitmap(icon_bitmap);

- prompt->set_icon(icon);

+ prompt->set_icon(icon_manager->GetIcon(extension_->id()));

return prompt;

}