[Refactor Xcode Objects] Enable navigator paths for file references.

[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while
path should be "ios/tool.cc", and they are different.

BUG=614818
Committed: https://crrev.com/d48f4812d85338487c72a7ab2b1c2db8d60dfdb0
Cr-Commit-Position: refs/heads/master@{#439429}

[liaoyuke, 2016-12-14 20:06:22]

Description was changed from

==========
[Refactor Xcode objects]: enables specifying navigator path for file references.

BUG=
==========

to

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

BUG=614818
==========

[liaoyuke, 2016-12-14 20:06:22]

liaoyuke@chromium.org changed reviewers:
+ justincohen@chromium.org, sdefresne@chromium.org

[liaoyuke, 2016-12-14 20:06:43]

Hi Sylvain, Justin,

Please take a look.

Thank you very much!

[liaoyuke, 2016-12-16 22:23:43]

Description was changed from

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

BUG=614818
==========

to

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while
path should be "ios/tool.cc", and they are different.

BUG=614818
==========

[liaoyuke, 2016-12-16 22:24:29]

Description was changed from

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while
path should be "ios/tool.cc", and they are different.

BUG=614818
==========

to

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference 
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while 
path should be "ios/tool.cc", and they are different.

BUG=614818
==========

[sdefresne, 2016-12-16 23:47:59]

lgtm once the inline function is renamed.

You'll also need to ask OWNERS approval from dpranke@ or brettw@.

https://codereview.chromium.org/2576773002/diff/40001/ios/build/tools/convert...
File ios/build/tools/convert_gn_xcodeproj.py (left):

https://codereview.chromium.org/2576773002/diff/40001/ios/build/tools/convert...
ios/build/tools/convert_gn_xcodeproj.py:103: # Remove path name key and change
path to basename.
Thank you for fixing this in the gn generator :-)

https://codereview.chromium.org/2576773002/diff/40001/tools/gn/xcode_object.h
File tools/gn/xcode_object.h (right):

https://codereview.chromium.org/2576773002/diff/40001/tools/gn/xcode_object.h...
tools/gn/xcode_object.h:223: void SetIsSource(const bool is_source) { is_source_
= is_source; }
I think it should be called "set_is_source" according to the style guide since
it is inline. Maybe also add a getter for the value?

[Dirk Pranke, 2016-12-18 03:24:36]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-12-18 03:24:37]

lgtm w/ comments addressed.

[liaoyuke, 2016-12-18 21:15:13]

The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-18 21:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-18 21:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-18 21:33:26]

Dry run: This issue passed the CQ dry run.

[liaoyuke, 2016-12-19 08:00:28]

The CQ bit was checked by liaoyuke@chromium.org

[liaoyuke, 2016-12-19 08:00:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2576773002/#ps60001
(title: "Addressed feedback")

[commit-bot: I haz the power, 2016-12-19 08:00:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 08:04:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482134428985590,
"parent_rev": "799bb4716f6b245a41e7e65d7d098665df67009c", "commit_rev":
"9ec6ff28a85609945d1b38e955f5fa9bdd4582e5"}

[commit-bot: I haz the power, 2016-12-19 08:04:38]

Description was changed from

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference 
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while 
path should be "ios/tool.cc", and they are different.

BUG=614818
==========

to

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference 
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while 
path should be "ios/tool.cc", and they are different.

BUG=614818

Review-Url: https://codereview.chromium.org/2576773002
==========

[liaoyuke, 2016-12-19 08:04:39]

Thank you very much for reviewing!

https://codereview.chromium.org/2576773002/diff/40001/ios/build/tools/convert...
File ios/build/tools/convert_gn_xcodeproj.py (left):

https://codereview.chromium.org/2576773002/diff/40001/ios/build/tools/convert...
ios/build/tools/convert_gn_xcodeproj.py:103: # Remove path name key and change
path to basename.
On 2016/12/16 23:47:58, sdefresne wrote:
> Thank you for fixing this in the gn generator :-)

You're most welcome :)

https://codereview.chromium.org/2576773002/diff/40001/tools/gn/xcode_object.h
File tools/gn/xcode_object.h (right):

https://codereview.chromium.org/2576773002/diff/40001/tools/gn/xcode_object.h...
tools/gn/xcode_object.h:223: void SetIsSource(const bool is_source) { is_source_
= is_source; }
On 2016/12/16 23:47:58, sdefresne wrote:
> I think it should be called "set_is_source" according to the style guide since
> it is inline. Maybe also add a getter for the value?

Done.

[commit-bot: I haz the power, 2016-12-19 08:04:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-19 08:07:07]

Description was changed from

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was 
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a 
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference 
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while 
path should be "ios/tool.cc", and they are different.

BUG=614818

Review-Url: https://codereview.chromium.org/2576773002
==========

to

==========
[Refactor Xcode Objects] Enable navigator paths for file references.

Previously, the folder hierarchy of a file reference in project navigator was
forced to be the same as its physical folder hierarchy on disk.

This CL refactors xcode_object.h and xcode_object.cc to enable specifying a
navigator folder hierarchy when generating a file reference and it is allowed to
be completely different from the physical one.

This CL also corrects the mi-uses between "name" and "path" in PBXFileReference
and PBXGroup. Take "ios/tool.cc" as an example, name should be "tool.cc", while
path should be "ios/tool.cc", and they are different.

BUG=614818

Committed: https://crrev.com/d48f4812d85338487c72a7ab2b1c2db8d60dfdb0
Cr-Commit-Position: refs/heads/master@{#439429}
==========

[commit-bot: I haz the power, 2016-12-19 08:07:08]

Patchset 4 (id:??) landed as
https://crrev.com/d48f4812d85338487c72a7ab2b1c2db8d60dfdb0
Cr-Commit-Position: refs/heads/master@{#439429}