Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: ios/build/tools/convert_gn_xcodeproj.py

Issue 2576773002: [Refactor Xcode Objects] Enable navigator paths for file references. (Closed)
Patch Set: Addressed feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/xcode_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/build/tools/convert_gn_xcodeproj.py
diff --git a/ios/build/tools/convert_gn_xcodeproj.py b/ios/build/tools/convert_gn_xcodeproj.py
index 668104f6e3b2d9f4a4445949cc90420924a68a50..c7b8c12d37c2c9c97695fcc5bcf8516ef6a1f392 100755
--- a/ios/build/tools/convert_gn_xcodeproj.py
+++ b/ios/build/tools/convert_gn_xcodeproj.py
@@ -100,12 +100,6 @@ def UpdateProductsProject(file_input, file_output, configurations):
if 'IPHONEOS_DEPLOYMENT_TARGET' not in build_settings:
build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
- # Remove path name key and change path to basename.
- if isa == 'PBXFileReference':
- if 'name' in value:
- del value['name']
- value['path'] = os.path.basename(value['path'])
-
# Teach build shell script to look for the configuration and platform.
if isa == 'PBXShellScriptBuildPhase':
value['shellScript'] = value['shellScript'].replace(
« no previous file with comments | « no previous file | tools/gn/xcode_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698