Remove last vestigial uses of "update needed" png assets.

Remove last vestigial uses of "update needed" png assets.

They were out of date, and in some cases redundant. Remove
the redundant uses completely and replace the others with
references to the vector versions.

BUG=673995
Committed: https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86
Cr-Commit-Position: refs/heads/master@{#438728}

[Evan Stade, 2016-12-14 17:21:33]

Description was changed from

==========
wip

BUG=673995
==========

to

==========
Remove last vestigial uses of "update needed" png assets.

They were out of date, and in some cases redundant. Remove
the redundant uses completely and replace the others with
references to the vector versions.

BUG=673995
==========

[Evan Stade, 2016-12-14 17:21:33]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-12-14 17:21:39]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 17:21:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-12-14 18:22:37]

LGTM

[commit-bot: I haz the power, 2016-12-14 18:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 18:24:49]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-12-14 18:26:15]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-12-14 18:27:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 18:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 18:59:54]

Failed to apply patch for
chrome/browser/recovery/recovery_install_global_error.cc:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/recovery/recovery_install_global_error.cc:42
  error: chrome/browser/recovery/recovery_install_global_error.cc: patch does
not apply

Patch:       chrome/browser/recovery/recovery_install_global_error.cc
Index: chrome/browser/recovery/recovery_install_global_error.cc
diff --git a/chrome/browser/recovery/recovery_install_global_error.cc
b/chrome/browser/recovery/recovery_install_global_error.cc
index
737647cab5e3281df25641d2007e54a0faddc3ad..79fb1ab934665922bb4310657e51b7d4c82ca2de
100644
--- a/chrome/browser/recovery/recovery_install_global_error.cc
+++ b/chrome/browser/recovery/recovery_install_global_error.cc
@@ -14,10 +14,11 @@
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
-#include "chrome/grit/theme_resources.h"
 #include "components/prefs/pref_service.h"
 #include "ui/base/l10n/l10n_util.h"
-#include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/paint_vector_icon.h"
+#include "ui/gfx/vector_icons_public.h"
+#include "ui/native_theme/native_theme.h"
 
 RecoveryInstallGlobalError::RecoveryInstallGlobalError(Profile* profile)
         : elevation_needed_(false),
@@ -42,8 +43,7 @@
RecoveryInstallGlobalError::RecoveryInstallGlobalError(Profile* profile)
                  base::Unretained(this)));
 }
 
-RecoveryInstallGlobalError::~RecoveryInstallGlobalError() {
-}
+RecoveryInstallGlobalError::~RecoveryInstallGlobalError() {}
 
 void RecoveryInstallGlobalError::Shutdown() {
   GlobalErrorServiceFactory::GetForProfile(profile_)->RemoveGlobalError(this);
@@ -66,8 +66,10 @@ base::string16 RecoveryInstallGlobalError::MenuItemLabel() {
 }
 
 gfx::Image RecoveryInstallGlobalError::MenuItemIcon() {
-  return ResourceBundle::GetSharedInstance().GetNativeImageNamed(
-      IDR_UPDATE_MENU_SEVERITY_HIGH);
+  return gfx::Image(gfx::CreateVectorIcon(
+      gfx::VectorIconId::BROWSER_TOOLS_UPDATE,
+      ui::NativeTheme::GetInstanceForNativeUi()->GetSystemColor(
+          ui::NativeTheme::kColorId_AlertSeverityHigh)));
 }
 
 void RecoveryInstallGlobalError::ExecuteMenuItem(Browser* browser) {
@@ -92,8 +94,9 @@ bool RecoveryInstallGlobalError::ShouldCloseOnDeactivate()
const {
 }
 
 gfx::Image RecoveryInstallGlobalError::GetBubbleViewIcon() {
-  return ResourceBundle::GetSharedInstance().GetNativeImageNamed(
-      IDR_UPDATE_MENU_SEVERITY_HIGH);
+  // TODO(estade): there shouldn't be an icon in the bubble, but
+  // GlobalErrorBubbleView currently requires it. See crbug.com/673995
+  return MenuItemIcon();
 }
 
 base::string16 RecoveryInstallGlobalError::GetBubbleViewTitle() {

[Evan Stade, 2016-12-15 00:51:15]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-15 00:51:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2576643002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-15 00:51:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:58:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2016-12-15 03:11:43]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-12-15 03:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 03:58:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481771503967950,
"parent_rev": "079bc9a7e410e82940fac2fe488df1d0361395bb", "commit_rev":
"edaedc6593492418fca83e967d69947daad17d04"}

[commit-bot: I haz the power, 2016-12-15 03:58:39]

Description was changed from

==========
Remove last vestigial uses of "update needed" png assets.

They were out of date, and in some cases redundant. Remove
the redundant uses completely and replace the others with
references to the vector versions.

BUG=673995
==========

to

==========
Remove last vestigial uses of "update needed" png assets.

They were out of date, and in some cases redundant. Remove
the redundant uses completely and replace the others with
references to the vector versions.

BUG=673995

Review-Url: https://codereview.chromium.org/2576643002
==========

[commit-bot: I haz the power, 2016-12-15 03:58:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 04:00:54]

Description was changed from

==========
Remove last vestigial uses of "update needed" png assets.

They were out of date, and in some cases redundant. Remove
the redundant uses completely and replace the others with
references to the vector versions.

BUG=673995

Review-Url: https://codereview.chromium.org/2576643002
==========

to

==========
Remove last vestigial uses of "update needed" png assets.

They were out of date, and in some cases redundant. Remove
the redundant uses completely and replace the others with
references to the vector versions.

BUG=673995

Committed: https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86
Cr-Commit-Position: refs/heads/master@{#438728}
==========

[commit-bot: I haz the power, 2016-12-15 04:00:55]

Patchset 3 (id:??) landed as
https://crrev.com/c821f28d145007603d0c1881075dd6ddbc97cf86
Cr-Commit-Position: refs/heads/master@{#438728}