Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2576513002: [Merge-M56] arc: Change default button to 'Agree' for Arc OOBE OptIn page. (Closed)

Created:
4 years ago by khmel
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge-M56] arc: Change default button to 'Agree' for Arc OOBE OptIn page. There is new requirement for buttons in Arc OOBE OptIn page. Skip and Agree buttons must be grayed until ToS is loaded. Once ToS is loaded both are enabled and 'Agree' button has the focus. This also moves focus to 'Retry' button in case of ToS loading failure. TEST=Manually on device. BUG=672145 TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2565573002 Cr-Commit-Position: refs/heads/master@{#437427} (cherry picked from commit ff1fb50a9ffa4b0461bc10db6bad8680ddce5f5b) Review-Url: https://codereview.chromium.org/2576513002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2576513002/1
4 years ago (2016-12-13 16:12:45 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-13 16:14:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698