Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2565573002: arc: Change default button to 'Agree' for Arc OOBE OptIn page. (Closed)

Created:
4 years ago by khmel
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Change default button to 'Agree' for Arc OOBE OptIn page. There is new requirement for buttons in Arc OOBE OptIn page. Skip and Agree buttons must be grayed until ToS is loaded. Once ToS is loaded both are enabled and 'Agree' button has the focus. This also moves focus to 'Retry' button in case of ToS loading failure. TEST=Manually on device. BUG=672145 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ff1fb50a9ffa4b0461bc10db6bad8680ddce5f5b Cr-Commit-Position: refs/heads/master@{#437427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
khmel
Hi Xiyuan, PTAL
4 years ago (2016-12-08 21:30:54 UTC) #3
xiyuan
lgtm
4 years ago (2016-12-08 21:57:50 UTC) #4
khmel
Thank you!
4 years ago (2016-12-08 22:47:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565573002/1
4 years ago (2016-12-08 22:48:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/352867)
4 years ago (2016-12-08 23:29:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565573002/1
4 years ago (2016-12-08 23:42:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 02:00:01 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 02:03:59 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff1fb50a9ffa4b0461bc10db6bad8680ddce5f5b
Cr-Commit-Position: refs/heads/master@{#437427}

Powered by Google App Engine
This is Rietveld 408576698