Adding feature flag for Android Pay v2 Chrome integration.

Adding feature flag for Android Pay v2 Chrome integration.

BUG=674367
Committed: https://crrev.com/06bbc97a88c04c3f955f3314bd73ecfda688e001
Cr-Commit-Position: refs/heads/master@{#438959}

[Walter Cacau, 2016-12-15 03:17:48]

Description was changed from

==========
Adding feature flag for Android Pay v2 Chrome integration.

BUG=674367
==========

to

==========
Adding feature flag for Android Pay v2 Chrome integration.

BUG=674367
==========

[Walter Cacau, 2016-12-15 03:17:48]

waltercacau@chromium.org changed reviewers:
+ rouslan@chromium.org

[Walter Cacau, 2016-12-15 03:50:44]

The CQ bit was checked by waltercacau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 03:50:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 04:34:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Walter Cacau, 2016-12-15 05:11:07]

The CQ bit was checked by waltercacau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 05:11:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 06:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 06:13:16]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-12-15 14:27:33]

You need someone from https://cs.chromium.org/chromium/src/tools/metrics/OWNERS
to approve the change in the histograms file.

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15456: +      <message
name="IDS_FLAGS_ENABLE_ANDROID_PAY_INTEGRATION_V2_NAME" desc="Name of the flag
to enable the second version of Android Pay integration">
Mark this non-translatable. Chrome does not translate anything
developer-centric.

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15459: +      <message
name="IDS_FLAGS_ENABLE_ANDROID_PAY_INTEGRATION_V2_DESCRIPTION" desc="Description
for the flag to enable the second version of Android Pay integration">
Ditto

[Walter Cacau, 2016-12-15 16:55:01]

waltercacau@chromium.org changed reviewers:
+ isherman@chromium.org

[Walter Cacau, 2016-12-15 16:58:16]

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15456: +      <message
name="IDS_FLAGS_ENABLE_ANDROID_PAY_INTEGRATION_V2_NAME" desc="Name of the flag
to enable the second version of Android Pay integration">
On 2016/12/15 14:27:33, rouslan wrote:
> Mark this non-translatable. Chrome does not translate anything
> developer-centric.

Done
should I change the above strings as well? Mostly copy pasted from this CL:
https://codereview.chromium.org/2074553002

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15459: +      <message
name="IDS_FLAGS_ENABLE_ANDROID_PAY_INTEGRATION_V2_DESCRIPTION" desc="Description
for the flag to enable the second version of Android Pay integration">
On 2016/12/15 14:27:33, rouslan wrote:
> Ditto

Done.

[please use gerrit instead, 2016-12-15 17:08:59]

lgtm % comment

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15456: +      <message
name="IDS_FLAGS_ENABLE_ANDROID_PAY_INTEGRATION_V2_NAME" desc="Name of the flag
to enable the second version of Android Pay integration">
On 2016/12/15 16:58:16, Walter Cacau wrote:
> On 2016/12/15 14:27:33, rouslan wrote:
> > Mark this non-translatable. Chrome does not translate anything
> > developer-centric.
> 
> Done
> should I change the above strings as well? Mostly copy pasted from this CL:
> https://codereview.chromium.org/2074553002

Yes, please.

[Walter Cacau, 2016-12-15 17:27:26]

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2576293002/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:15456: +      <message
name="IDS_FLAGS_ENABLE_ANDROID_PAY_INTEGRATION_V2_NAME" desc="Name of the flag
to enable the second version of Android Pay integration">
On 2016/12/15 17:08:59, rouslan wrote:
> On 2016/12/15 16:58:16, Walter Cacau wrote:
> > On 2016/12/15 14:27:33, rouslan wrote:
> > > Mark this non-translatable. Chrome does not translate anything
> > > developer-centric.
> > 
> > Done
> > should I change the above strings as well? Mostly copy pasted from this CL:
> > https://codereview.chromium.org/2074553002
> 
> Yes, please.

Done.

[Walter Cacau, 2016-12-15 18:07:00]

The CQ bit was checked by waltercacau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 18:07:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 19:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 19:15:59]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-12-15 23:08:52]

histograms.xml lgtm

[Walter Cacau, 2016-12-15 23:17:01]

The CQ bit was checked by waltercacau@chromium.org

[Walter Cacau, 2016-12-15 23:17:02]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2576293002/#ps80001
(title: "marking more strings as non translatable")

[commit-bot: I haz the power, 2016-12-15 23:18:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 23:58:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481843821587900,
"parent_rev": "c5e6cce8a085b236bf7ef4f092fd4eb997ffd692", "commit_rev":
"e60ef2686366a41832cb656bde5d5a53437cfaea"}

[commit-bot: I haz the power, 2016-12-15 23:58:38]

Description was changed from

==========
Adding feature flag for Android Pay v2 Chrome integration.

BUG=674367
==========

to

==========
Adding feature flag for Android Pay v2 Chrome integration.

BUG=674367

Review-Url: https://codereview.chromium.org/2576293002
==========

[commit-bot: I haz the power, 2016-12-15 23:58:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-16 00:02:34]

Description was changed from

==========
Adding feature flag for Android Pay v2 Chrome integration.

BUG=674367

Review-Url: https://codereview.chromium.org/2576293002
==========

to

==========
Adding feature flag for Android Pay v2 Chrome integration.

BUG=674367

Committed: https://crrev.com/06bbc97a88c04c3f955f3314bd73ecfda688e001
Cr-Commit-Position: refs/heads/master@{#438959}
==========

[commit-bot: I haz the power, 2016-12-16 00:02:35]

Patchset 5 (id:??) landed as
https://crrev.com/06bbc97a88c04c3f955f3314bd73ecfda688e001
Cr-Commit-Position: refs/heads/master@{#438959}