Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2074553002: Flag to disable Android Pay v1 integration. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Walter Cacau
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flag to disable Android Pay v1 integration. BUG=620173 Committed: https://crrev.com/52cb37c9019660636374ed606a7de250351143c8 Cr-Commit-Position: refs/heads/master@{#400490}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Combine 2 android blocks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074553002/1
4 years, 6 months ago (2016-06-16 00:47:02 UTC) #2
please use gerrit instead
dfalcantara@, ptal. waltercacau@, fyi.
4 years, 6 months ago (2016-06-16 00:47:24 UTC) #4
Walter Cacau
lgtm
4 years, 6 months ago (2016-06-16 01:06:31 UTC) #6
Walter Cacau
lgtm
4 years, 6 months ago (2016-06-16 01:06:33 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/128074)
4 years, 6 months ago (2016-06-16 02:09:14 UTC) #9
gone
lgtm https://chromiumcodereview.appspot.com/2074553002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/2074553002/diff/1/chrome/browser/about_flags.cc#newcode1917 chrome/browser/about_flags.cc:1917: {"enable-android-pay-integration-v1", Any objection to moving this into the ...
4 years, 6 months ago (2016-06-16 17:52:44 UTC) #10
please use gerrit instead
holte@, ptal histograms.xml https://chromiumcodereview.appspot.com/2074553002/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://chromiumcodereview.appspot.com/2074553002/diff/1/chrome/browser/about_flags.cc#newcode1917 chrome/browser/about_flags.cc:1917: {"enable-android-pay-integration-v1", On 2016/06/16 17:52:44, dfalcantara wrote: ...
4 years, 6 months ago (2016-06-16 18:09:03 UTC) #12
Steven Holte
On 2016/06/16 18:09:03, Rouslan (ツ) wrote: > holte@, ptal histograms.xml > > https://chromiumcodereview.appspot.com/2074553002/diff/1/chrome/browser/about_flags.cc > File ...
4 years, 6 months ago (2016-06-17 19:19:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2074553002/20001
4 years, 6 months ago (2016-06-17 19:30:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 20:35:24 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 20:36:55 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/52cb37c9019660636374ed606a7de250351143c8
Cr-Commit-Position: refs/heads/master@{#400490}

Powered by Google App Engine
This is Rietveld 408576698