Introducing WebCoalescedInputEvent and inclusion in content/common

Introducing WebCoalescedInputEvent and inclusion in content/common

BUG=656781
TBR=kmarshall@chromium.org

Review-Url: https://codereview.chromium.org/2576013002
Cr-Commit-Position: refs/heads/master@{#442360}
Committed: https://chromium.googlesource.com/chromium/src/+/c53850d9abcf33808e245fc4f17145ca5822081d

[Navid Zolghadr, 2016-12-14 21:21:47]

nzolghadr@chromium.org changed reviewers:
+ dglazkov@chromium.org, dtapuska@chromium.org, esprehn@chromium.org

[Navid Zolghadr, 2016-12-14 21:21:48]

ptal. This is a smaller version of adding WebCoalescedInputEvent. Note that it
is not all the plumbing to keep the change as small and it only shows a few key
files that need changing. Let me know what you think.

I also updated the design doc here with the two possible solutions for this
case.
https://docs.google.com/document/d/1x-e8fH3I0DBrmrNufPQwRJHMYnW5q9CYZVEHe7Bsf...

[dglazkov, 2016-12-15 16:01:54]

Approach LGTM.

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebCoalescedInputEvent.h (right):

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCoalescedInputEvent.h:2: * Copyright (C)
2009 Google Inc. All rights reserved.
Can we use use new-style header here?

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCoalescedInputEvent.h:69: typedef
std::unique_ptr<WebCoalescedInputEvent> ScopedCoalescedWebInputEvent;
WebScopedCoalescedInputEvent or ScopedWebCoalescedInputEvent maybe? :)

[Navid Zolghadr, 2016-12-16 15:38:09]

So is it okay that I move forward with adding the rest of the plumbing?

Particularly just to make sure you are okay with this statement I re-iterate:
Is the inclusion of WebCoalescedInputEvent in content/common/DEPS okay?

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebCoalescedInputEvent.h (right):

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCoalescedInputEvent.h:2: * Copyright (C)
2009 Google Inc. All rights reserved.
On 2016/12/15 16:01:54, dglazkov wrote:
> Can we use use new-style header here?

That's weird. I'm pretty sure I copy pasted the new chromium copy right here.
But I guess I lost that part of the change. I'll fix it.

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCoalescedInputEvent.h:69: typedef
std::unique_ptr<WebCoalescedInputEvent> ScopedCoalescedWebInputEvent;
On 2016/12/15 16:01:54, dglazkov wrote:
> WebScopedCoalescedInputEvent or ScopedWebCoalescedInputEvent maybe? :)

Sure. How about ScopedWebInputEvent? Do you like that also to be
WebScopedInputEvent?

[esprehn, 2016-12-20 20:44:50]

lgtm

[esprehn, 2016-12-20 20:46:18]

Please use the short copyright.

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebCoalescedInputEvent.cpp (right):

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebCoalescedInputEvent.cpp:2: * Copyright (C) 2009
Google Inc. All rights reserved.
2009? Also use the short copyright for new files.

[Navid Zolghadr, 2016-12-22 20:50:34]

ptal.

Please note that I had to add WebCoalescedInputEvent to blink_common target
which is the most important change from the last patch to get things to compile
correctly.

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebCoalescedInputEvent.cpp (right):

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebCoalescedInputEvent.cpp:2: * Copyright (C) 2009
Google Inc. All rights reserved.
On 2016/12/20 20:46:18, esprehn wrote:
> 2009? Also use the short copyright for new files.

Done.

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebCoalescedInputEvent.h (right):

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCoalescedInputEvent.h:2: * Copyright (C)
2009 Google Inc. All rights reserved.
On 2016/12/16 15:38:08, Navid Zolghadr wrote:
> On 2016/12/15 16:01:54, dglazkov wrote:
> > Can we use use new-style header here?
> 
> That's weird. I'm pretty sure I copy pasted the new chromium copy right here.
> But I guess I lost that part of the change. I'll fix it.

Done.

https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebCoalescedInputEvent.h:69: typedef
std::unique_ptr<WebCoalescedInputEvent> ScopedCoalescedWebInputEvent;
On 2016/12/16 15:38:09, Navid Zolghadr wrote:
> On 2016/12/15 16:01:54, dglazkov wrote:
> > WebScopedCoalescedInputEvent or ScopedWebCoalescedInputEvent maybe? :)
> 
> Sure. How about ScopedWebInputEvent? Do you like that also to be
> WebScopedInputEvent?

I changed them all to start with Web

[Navid Zolghadr, 2016-12-22 21:08:58]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 21:09:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 21:12:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 21:12:17]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dtapuska, 2017-01-03 19:36:50]

On 2016/12/22 20:50:34, Navid Zolghadr wrote:
> ptal.
> 
> Please note that I had to add WebCoalescedInputEvent to blink_common target
> which is the most important change from the last patch to get things to
compile
> correctly.
> 
>
https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/Source/w...
> File third_party/WebKit/Source/web/WebCoalescedInputEvent.cpp (right):
> 
>
https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/Source/w...
> third_party/WebKit/Source/web/WebCoalescedInputEvent.cpp:2: * Copyright (C)
2009
> Google Inc. All rights reserved.
> On 2016/12/20 20:46:18, esprehn wrote:
> > 2009? Also use the short copyright for new files.
> 
> Done.
> 
>
https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
> File third_party/WebKit/public/platform/WebCoalescedInputEvent.h (right):
> 
>
https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
> third_party/WebKit/public/platform/WebCoalescedInputEvent.h:2: * Copyright (C)
> 2009 Google Inc. All rights reserved.
> On 2016/12/16 15:38:08, Navid Zolghadr wrote:
> > On 2016/12/15 16:01:54, dglazkov wrote:
> > > Can we use use new-style header here?
> > 
> > That's weird. I'm pretty sure I copy pasted the new chromium copy right
here.
> > But I guess I lost that part of the change. I'll fix it.
> 
> Done.
> 
>
https://codereview.chromium.org/2576013002/diff/1/third_party/WebKit/public/p...
> third_party/WebKit/public/platform/WebCoalescedInputEvent.h:69: typedef
> std::unique_ptr<WebCoalescedInputEvent> ScopedCoalescedWebInputEvent;
> On 2016/12/16 15:38:09, Navid Zolghadr wrote:
> > On 2016/12/15 16:01:54, dglazkov wrote:
> > > WebScopedCoalescedInputEvent or ScopedWebCoalescedInputEvent maybe? :)
> > 
> > Sure. How about ScopedWebInputEvent? Do you like that also to be
> > WebScopedInputEvent?
> 
> I changed them all to start with Web

lgtm

[Navid Zolghadr, 2017-01-04 16:36:51]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 16:37:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 16:52:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 16:52:29]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Navid Zolghadr, 2017-01-04 17:18:06]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 17:18:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 17:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 17:41:11]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Navid Zolghadr, 2017-01-04 19:28:30]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:29:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:18:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:18:56]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Navid Zolghadr, 2017-01-05 21:35:57]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:36:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 22:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:26:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Navid Zolghadr, 2017-01-06 20:31:44]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 20:32:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:13:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:13:07]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Navid Zolghadr, 2017-01-09 17:44:08]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 17:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:37:27]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2017-01-09 19:54:09]

nzolghadr@chromium.org changed reviewers:
+ avi@chromium.org, dcheng@chromium.org, kmarshall@chromium.org

[Navid Zolghadr, 2017-01-09 19:54:10]

kmarshall@chromium.org: Please review changes in 
blimp/*

dcheng@chromium.org: Please review changes in 
content/common/input/*

avi@chromium.org: Please review changes in 
content/browser/devtools/protocol/input_handler.cc
content/common/DEPS

[dcheng, 2017-01-09 20:36:17]

ipc changes in content/common/input lgtm

[Avi (use Gerrit), 2017-01-09 20:39:39]

> mailto:avi@chromium.org: Please review changes in 
> content/browser/devtools/protocol/input_handler.cc
> content/common/DEPS

Those files LGTM

[Navid Zolghadr, 2017-01-09 21:33:23]

Description was changed from

==========
Introducing WebCoalescedInputEvent and inclusion in content/common

BUG=656781
==========

to

==========
Introducing WebCoalescedInputEvent and inclusion in content/common

BUG=656781

TBR=kmarshall@chromium.org
==========

[Navid Zolghadr, 2017-01-09 21:33:44]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-01-09 21:33:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, dglazkov@chromium.org, dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2576013002/#ps140001
(title: "Fix a few DCHECK hits")

[commit-bot: I haz the power, 2017-01-09 21:34:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 21:42:11]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1483997624479570,
"parent_rev": "f65aa1847f78fb5a5d944723de974906e987f544", "commit_rev":
"c53850d9abcf33808e245fc4f17145ca5822081d"}

[commit-bot: I haz the power, 2017-01-09 21:42:42]

Description was changed from

==========
Introducing WebCoalescedInputEvent and inclusion in content/common

BUG=656781

TBR=kmarshall@chromium.org
==========

to

==========
Introducing WebCoalescedInputEvent and inclusion in content/common

BUG=656781

TBR=kmarshall@chromium.org

Review-Url: https://codereview.chromium.org/2576013002
Cr-Commit-Position: refs/heads/master@{#442360}
Committed:
https://chromium.googlesource.com/chromium/src/+/c53850d9abcf33808e245fc4f171...
==========

[commit-bot: I haz the power, 2017-01-09 21:42:44]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/c53850d9abcf33808e245fc4f171...

[foolip, 2017-01-24 04:56:26]

foolip@chromium.org changed reviewers:
+ foolip@chromium.org

[foolip, 2017-01-24 04:56:27]

https://codereview.chromium.org/2576013002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/PointerEventFactory.cpp (right):

https://codereview.chromium.org/2576013002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/PointerEventFactory.cpp:266:
DCHECK_EQ(mouseEvent.pointerProperties().pointerType,
Filed https://bugs.chromium.org/p/chromium/issues/detail?id=684292 for this
DCHECK_EQ failing on Mac.