Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257563003: DevTools: Unify ADB-related browser tests (Closed)

Created:
6 years, 8 months ago by Vladislav Kaznacheev
Modified:
6 years, 8 months ago
Reviewers:
Dmitry Zvorygin
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

DevTools: Unify ADB-related browser tests Merged devtools_android_bridge_browsertest.cc logic into adb_client_socket_browser_test.cc. Made inspect_ui_browsertest.cc use MockAdbServer instead of a mock DeviceProvider. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266302

Patch Set 1 #

Patch Set 2 : Smaller diff #

Patch Set 3 : Fixed clang compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+661 lines, -758 lines) Patch
M chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc View 1 1 chunk +79 lines, -373 lines 0 comments Download
A chrome/browser/devtools/device/adb/mock_adb_server.h View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/browser/devtools/device/adb/mock_adb_server.cc View 1 2 1 chunk +557 lines, -0 lines 0 comments Download
M chrome/browser/devtools/device/android_device_manager.h View 2 chunks +3 lines, -5 lines 0 comments Download
D chrome/browser/devtools/device/devtools_android_bridge_browsertest.cc View 1 chunk +0 lines, -378 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui_browsertest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
Vladislav Kaznacheev
6 years, 8 months ago (2014-04-24 10:37:59 UTC) #1
Dmitry Zvorygin
On 2014/04/24 10:37:59, Vladislav Kaznacheev wrote: Great change! LGTM.
6 years, 8 months ago (2014-04-24 11:11:55 UTC) #2
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 8 months ago (2014-04-24 11:19:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/257563003/1
6 years, 8 months ago (2014-04-24 11:28:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 11:32:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-24 11:32:27 UTC) #6
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 8 months ago (2014-04-24 13:37:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/257563003/40001
6 years, 8 months ago (2014-04-24 14:16:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 15:45:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 15:45:49 UTC) #10
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 8 months ago (2014-04-24 17:01:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/257563003/40001
6 years, 8 months ago (2014-04-24 17:02:26 UTC) #12
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 8 months ago (2014-04-24 20:14:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg tryserver.chromium on linux_chromium_clang_dbg tryserver.chromium on mac_chromium_compile_dbg ...
6 years, 8 months ago (2014-04-24 21:07:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/257563003/60001
6 years, 8 months ago (2014-04-24 21:13:50 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:37:28 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 22:37:30 UTC) #17
Vladislav Kaznacheev
The CQ bit was checked by kaznacheev@chromium.org
6 years, 8 months ago (2014-04-25 04:54:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/257563003/60001
6 years, 8 months ago (2014-04-25 07:57:34 UTC) #19
commit-bot: I haz the power
6 years, 8 months ago (2014-04-26 00:37:43 UTC) #20
Message was sent while issue was closed. 
Change committed as 266302

Powered by Google App Engine
This is Rietveld 408576698