Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: chrome/browser/ui/webui/inspect_ui_browsertest.cc

Issue 257563003: DevTools: Unify ADB-related browser tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed clang compile Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/device/devtools_android_bridge_browsertest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/inspect_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/inspect_ui_browsertest.cc b/chrome/browser/ui/webui/inspect_ui_browsertest.cc
index e6ad8bfe008ebb1db2c6a9a5ab00a29e1c3643a4..f70ddb6fcc7033779563e7a3dbdd1fd3c63fc546 100644
--- a/chrome/browser/ui/webui/inspect_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/inspect_ui_browsertest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/devtools/device/adb/mock_adb_server.h"
#include "chrome/browser/devtools/device/devtools_android_bridge.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ -71,12 +72,16 @@ IN_PROC_BROWSER_TEST_F(InspectUITest, AndroidTargets) {
scoped_refptr<DevToolsAndroidBridge> android_bridge =
DevToolsAndroidBridge::Factory::GetForProfile(browser()->profile());
AndroidDeviceManager::DeviceProviders providers;
- providers.push_back(AndroidDeviceManager::GetMockDeviceProviderForTest());
+ providers.push_back(AndroidDeviceManager::GetAdbDeviceProvider());
android_bridge->set_device_providers_for_test(providers);
+ StartMockAdbServer();
+
ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIInspectURL));
ASSERT_TRUE(WebUIBrowserTest::RunJavascriptAsyncTest("testAdbTargetsListed"));
+
+ StopMockAdbServer();
}
IN_PROC_BROWSER_TEST_F(InspectUITest, ReloadCrash) {
« no previous file with comments | « chrome/browser/devtools/device/devtools_android_bridge_browsertest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698