Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: chrome/browser/devtools/device/android_device_manager.h

Issue 257563003: DevTools: Unify ADB-related browser tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed clang compile Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/android_device_manager.h
diff --git a/chrome/browser/devtools/device/android_device_manager.h b/chrome/browser/devtools/device/android_device_manager.h
index ec25aa1b9243da96257d2dbc35ba5b42159629bd..4c147c7e2f9e4654fb356d2f0001b33837a30fd3 100644
--- a/chrome/browser/devtools/device/android_device_manager.h
+++ b/chrome/browser/devtools/device/android_device_manager.h
@@ -35,9 +35,9 @@ class AndroidDeviceManager
const CommandCallback& callback) = 0;
virtual void OpenSocket(const std::string& socket_name,
const SocketCallback& callback) = 0;
- virtual void HttpQuery(const std::string& la_name,
- const std::string& request,
- const CommandCallback& callback);
+ void HttpQuery(const std::string& la_name,
+ const std::string& request,
+ const CommandCallback& callback);
void HttpUpgrade(const std::string& la_name,
const std::string& request,
const SocketCallback& callback);
@@ -91,8 +91,6 @@ class AndroidDeviceManager
static scoped_refptr<DeviceProvider> GetUsbDeviceProvider(Profile* profile);
// Use only in a test and/or when DEBUG_DEVTOOLS is defined.
static scoped_refptr<DeviceProvider> GetSelfAsDeviceProvider(int port);
- // Implemented in browser_tests.
- static scoped_refptr<DeviceProvider> GetMockDeviceProviderForTest();
static scoped_refptr<AndroidDeviceManager> Create();

Powered by Google App Engine
This is Rietveld 408576698