Reland of strict transmission of external exp ids to signed in users.

Reland of strict transmission of external exp ids to signed in users. (patchset #1 id:1 of https://codereview.chromium.org/2569973002/ )

Reason for revert:
The CL was not a culprit for the issue.

Original issue's description:
> Revert of Restrict transmission of external exp ids to signed in users. (patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )
>
> Reason for revert:
> Speculative revert for recent flakiness in
> Contextual Search related test failures on
> "Android Tests" bot:
>
> https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuilds=100
>
> e.g. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/35779
>
> I'm not very confident that this is the real
> offender; if it's not, I will reland this CL.
>
> Original issue's description:
> > Restrict transmission of external exp ids to signed in users.
> >
> > Since external experiment ids are not based on Chrome's low
> > entropy source, they do not have the same guarantees about
> > not identifying a user as Chrome's variations. As such, we
> > should only transmit them for signed in users, whose identity
> > is already known by Google so there's no risk of identifying
> > them through these headers.
> >
> > Note: The signed-in state checking in this CL is only done for
> > web content area requests and not other internal requests,
> > like to the suggestion service, where it treats the state as
> > "not signed in". This is fine to do because variations service
> > ids are still sent, which is what the other call sites are
> > interested in.
> >
> > BUG=672532
> > TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org
> >
> > Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> > Cr-Commit-Position: refs/heads/master@{#437959}
>
> TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.org,mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,asvitkine@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=672532
>
> Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
> Cr-Commit-Position: refs/heads/master@{#438075}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.org,mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,asvitkine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532
Committed: https://crrev.com/3305f49d2532f5b0d2b184826197ee8f122ed4e7
Cr-Commit-Position: refs/heads/master@{#438117}

[Yuta Kitamura, 2016-12-13 10:31:13]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-12-13 10:31:13]

Created Reland of strict transmission of external exp ids to signed in users.

[commit-bot: I haz the power, 2016-12-13 10:31:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 10:32:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481625073215380, "parent_rev":
"2220cae41c0d2579feef20693eb9b1c708184bbe", "commit_rev":
"5ff361b4522f1cd6e3a74374aa3b6fee26c9e62f"}

[commit-bot: I haz the power, 2016-12-13 10:33:08]

Description was changed from

==========
Reland of strict transmission of external exp ids to signed in users. (patchset
#1 id:1 of https://codereview.chromium.org/2569973002/ )

Reason for revert:
The CL was not a culprit for the issue.

Original issue's description:
> Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )
> 
> Reason for revert:
> Speculative revert for recent flakiness in
> Contextual Search related test failures on
> "Android Tests" bot:
> 
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...
> 
> e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...
> 
> I'm not very confident that this is the real
> offender; if it's not, I will reland this CL.
> 
> Original issue's description:
> > Restrict transmission of external exp ids to signed in users.
> >
> > Since external experiment ids are not based on Chrome's low
> > entropy source, they do not have the same guarantees about
> > not identifying a user as Chrome's variations. As such, we
> > should only transmit them for signed in users, whose identity
> > is already known by Google so there's no risk of identifying
> > them through these headers.
> >
> > Note: The signed-in state checking in this CL is only done for
> > web content area requests and not other internal requests,
> > like to the suggestion service, where it treats the state as
> > "not signed in". This is fine to do because variations service
> > ids are still sent, which is what the other call sites are
> > interested in.
> >
> > BUG=672532
> >
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
> >
> > Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> > Cr-Commit-Position: refs/heads/master@{#437959}
> 
>
TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=672532
> 
> Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
> Cr-Commit-Position: refs/heads/master@{#438075}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532
==========

to

==========
Reland of strict transmission of external exp ids to signed in users. (patchset
#1 id:1 of https://codereview.chromium.org/2569973002/ )

Reason for revert:
The CL was not a culprit for the issue.

Original issue's description:
> Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )
> 
> Reason for revert:
> Speculative revert for recent flakiness in
> Contextual Search related test failures on
> "Android Tests" bot:
> 
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...
> 
> e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...
> 
> I'm not very confident that this is the real
> offender; if it's not, I will reland this CL.
> 
> Original issue's description:
> > Restrict transmission of external exp ids to signed in users.
> >
> > Since external experiment ids are not based on Chrome's low
> > entropy source, they do not have the same guarantees about
> > not identifying a user as Chrome's variations. As such, we
> > should only transmit them for signed in users, whose identity
> > is already known by Google so there's no risk of identifying
> > them through these headers.
> >
> > Note: The signed-in state checking in this CL is only done for
> > web content area requests and not other internal requests,
> > like to the suggestion service, where it treats the state as
> > "not signed in". This is fine to do because variations service
> > ids are still sent, which is what the other call sites are
> > interested in.
> >
> > BUG=672532
> >
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
> >
> > Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> > Cr-Commit-Position: refs/heads/master@{#437959}
> 
>
TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=672532
> 
> Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
> Cr-Commit-Position: refs/heads/master@{#438075}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Review-Url: https://codereview.chromium.org/2575483002
==========

[commit-bot: I haz the power, 2016-12-13 10:33:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 10:35:31]

Description was changed from

==========
Reland of strict transmission of external exp ids to signed in users. (patchset
#1 id:1 of https://codereview.chromium.org/2569973002/ )

Reason for revert:
The CL was not a culprit for the issue.

Original issue's description:
> Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )
> 
> Reason for revert:
> Speculative revert for recent flakiness in
> Contextual Search related test failures on
> "Android Tests" bot:
> 
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...
> 
> e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...
> 
> I'm not very confident that this is the real
> offender; if it's not, I will reland this CL.
> 
> Original issue's description:
> > Restrict transmission of external exp ids to signed in users.
> >
> > Since external experiment ids are not based on Chrome's low
> > entropy source, they do not have the same guarantees about
> > not identifying a user as Chrome's variations. As such, we
> > should only transmit them for signed in users, whose identity
> > is already known by Google so there's no risk of identifying
> > them through these headers.
> >
> > Note: The signed-in state checking in this CL is only done for
> > web content area requests and not other internal requests,
> > like to the suggestion service, where it treats the state as
> > "not signed in". This is fine to do because variations service
> > ids are still sent, which is what the other call sites are
> > interested in.
> >
> > BUG=672532
> >
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
> >
> > Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> > Cr-Commit-Position: refs/heads/master@{#437959}
> 
>
TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=672532
> 
> Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
> Cr-Commit-Position: refs/heads/master@{#438075}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Review-Url: https://codereview.chromium.org/2575483002
==========

to

==========
Reland of strict transmission of external exp ids to signed in users. (patchset
#1 id:1 of https://codereview.chromium.org/2569973002/ )

Reason for revert:
The CL was not a culprit for the issue.

Original issue's description:
> Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )
>
> Reason for revert:
> Speculative revert for recent flakiness in
> Contextual Search related test failures on
> "Android Tests" bot:
>
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...
>
> e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...
>
> I'm not very confident that this is the real
> offender; if it's not, I will reland this CL.
>
> Original issue's description:
> > Restrict transmission of external exp ids to signed in users.
> >
> > Since external experiment ids are not based on Chrome's low
> > entropy source, they do not have the same guarantees about
> > not identifying a user as Chrome's variations. As such, we
> > should only transmit them for signed in users, whose identity
> > is already known by Google so there's no risk of identifying
> > them through these headers.
> >
> > Note: The signed-in state checking in this CL is only done for
> > web content area requests and not other internal requests,
> > like to the suggestion service, where it treats the state as
> > "not signed in". This is fine to do because variations service
> > ids are still sent, which is what the other call sites are
> > interested in.
> >
> > BUG=672532
> >
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
> >
> > Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> > Cr-Commit-Position: refs/heads/master@{#437959}
>
>
TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=672532
>
> Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
> Cr-Commit-Position: refs/heads/master@{#438075}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Committed: https://crrev.com/3305f49d2532f5b0d2b184826197ee8f122ed4e7
Cr-Commit-Position: refs/heads/master@{#438117}
==========

[commit-bot: I haz the power, 2016-12-13 10:35:32]

Patchset 1 (id:??) landed as
https://crrev.com/3305f49d2532f5b0d2b184826197ee8f122ed4e7
Cr-Commit-Position: refs/heads/master@{#438117}