Revert of Restrict transmission of external exp ids to signed in users.

Revert of Restrict transmission of external exp ids to signed in users. (patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )

Reason for revert:
Speculative revert for recent flakiness in
Contextual Search related test failures on
"Android Tests" bot:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuilds=100

e.g. https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/35779

I'm not very confident that this is the real
offender; if it's not, I will reland this CL.

Original issue's description:
> Restrict transmission of external exp ids to signed in users.
>
> Since external experiment ids are not based on Chrome's low
> entropy source, they do not have the same guarantees about
> not identifying a user as Chrome's variations. As such, we
> should only transmit them for signed in users, whose identity
> is already known by Google so there's no risk of identifying
> them through these headers.
>
> Note: The signed-in state checking in this CL is only done for
> web content area requests and not other internal requests,
> like to the suggestion service, where it treats the state as
> "not signed in". This is fine to do because variations service
> ids are still sent, which is what the other call sites are
> interested in.
>
> BUG=672532
> TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org
>
> Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> Cr-Commit-Position: refs/heads/master@{#437959}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.org,mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,asvitkine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532
Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
Cr-Commit-Position: refs/heads/master@{#438075}

[Yuta Kitamura, 2016-12-13 06:05:56]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-12-13 06:05:56]

Created Revert of Restrict transmission of external exp ids to signed in users.

[commit-bot: I haz the power, 2016-12-13 06:06:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 06:08:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481609156372010, "parent_rev":
"876c30cdbb984700905e2ba5aa4fcf3630eac890", "commit_rev":
"77d538dca00d6c05a5941a766d23d57aedcc5c53"}

[commit-bot: I haz the power, 2016-12-13 06:09:07]

Description was changed from

==========
Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )

Reason for revert:
Speculative revert for recent flakiness in
Contextual Search related test failures on
"Android Tests" bot:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...

e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...

I'm not very confident that this is the real
offender; if it's not, I will reland this CL.

Original issue's description:
> Restrict transmission of external exp ids to signed in users.
> 
> Since external experiment ids are not based on Chrome's low
> entropy source, they do not have the same guarantees about
> not identifying a user as Chrome's variations. As such, we
> should only transmit them for signed in users, whose identity
> is already known by Google so there's no risk of identifying
> them through these headers.
> 
> Note: The signed-in state checking in this CL is only done for
> web content area requests and not other internal requests,
> like to the suggestion service, where it treats the state as
> "not signed in". This is fine to do because variations service
> ids are still sent, which is what the other call sites are
> interested in.
> 
> BUG=672532
>
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
> 
> Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> Cr-Commit-Position: refs/heads/master@{#437959}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532
==========

to

==========
Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )

Reason for revert:
Speculative revert for recent flakiness in
Contextual Search related test failures on
"Android Tests" bot:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...

e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...

I'm not very confident that this is the real
offender; if it's not, I will reland this CL.

Original issue's description:
> Restrict transmission of external exp ids to signed in users.
> 
> Since external experiment ids are not based on Chrome's low
> entropy source, they do not have the same guarantees about
> not identifying a user as Chrome's variations. As such, we
> should only transmit them for signed in users, whose identity
> is already known by Google so there's no risk of identifying
> them through these headers.
> 
> Note: The signed-in state checking in this CL is only done for
> web content area requests and not other internal requests,
> like to the suggestion service, where it treats the state as
> "not signed in". This is fine to do because variations service
> ids are still sent, which is what the other call sites are
> interested in.
> 
> BUG=672532
>
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
> 
> Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> Cr-Commit-Position: refs/heads/master@{#437959}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Review-Url: https://codereview.chromium.org/2569973002
==========

[commit-bot: I haz the power, 2016-12-13 06:09:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 06:14:37]

Description was changed from

==========
Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )

Reason for revert:
Speculative revert for recent flakiness in
Contextual Search related test failures on
"Android Tests" bot:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...

e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...

I'm not very confident that this is the real
offender; if it's not, I will reland this CL.

Original issue's description:
> Restrict transmission of external exp ids to signed in users.
> 
> Since external experiment ids are not based on Chrome's low
> entropy source, they do not have the same guarantees about
> not identifying a user as Chrome's variations. As such, we
> should only transmit them for signed in users, whose identity
> is already known by Google so there's no risk of identifying
> them through these headers.
> 
> Note: The signed-in state checking in this CL is only done for
> web content area requests and not other internal requests,
> like to the suggestion service, where it treats the state as
> "not signed in". This is fine to do because variations service
> ids are still sent, which is what the other call sites are
> interested in.
> 
> BUG=672532
>
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
> 
> Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> Cr-Commit-Position: refs/heads/master@{#437959}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Review-Url: https://codereview.chromium.org/2569973002
==========

to

==========
Revert of Restrict transmission of external exp ids to signed in users.
(patchset #6 id:140001 of https://codereview.chromium.org/2558913003/ )

Reason for revert:
Speculative revert for recent flakiness in
Contextual Search related test failures on
"Android Tests" bot:

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests?numbuild...

e.g.
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/3...

I'm not very confident that this is the real
offender; if it's not, I will reland this CL.

Original issue's description:
> Restrict transmission of external exp ids to signed in users.
>
> Since external experiment ids are not based on Chrome's low
> entropy source, they do not have the same guarantees about
> not identifying a user as Chrome's variations. As such, we
> should only transmit them for signed in users, whose identity
> is already known by Google so there's no risk of identifying
> them through these headers.
>
> Note: The signed-in state checking in this CL is only done for
> web content area requests and not other internal requests,
> like to the suggestion service, where it treats the state as
> "not signed in". This is fine to do because variations service
> ids are still sent, which is what the other call sites are
> interested in.
>
> BUG=672532
>
TBR=mpearson@chromium.org,mattm@chromium.org,donnd@chromium.org,afakhry@chrom...
>
> Committed: https://crrev.com/9ed7b5611a61505c3dba734fe55b92211df3c2f6
> Cr-Commit-Position: refs/heads/master@{#437959}

TBR=jwd@chromium.org,mathp@chromium.org,treib@chromium.org,mmenke@chromium.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=672532

Committed: https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
Cr-Commit-Position: refs/heads/master@{#438075}
==========

[commit-bot: I haz the power, 2016-12-13 06:14:39]

Patchset 1 (id:??) landed as
https://crrev.com/e48e108c244a245ec42966584c02752ee1be7d9c
Cr-Commit-Position: refs/heads/master@{#438075}

[Yuta Kitamura, 2016-12-13 10:31:13]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2575483002/ by yutak@chromium.org.

The reason for reverting is: The CL was not a culprit for the issue..