Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2575343003: Hide the "Move to other window" menu option when there is only one tab (Closed)

Created:
4 years ago by Theresa
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide the "Move to other window" menu option when there is only one tab If the last tab is moved to the other window and the device has a home page, the original activity closes, which leads to a weird, confusing animation. There's not a strong use case for having two windows open with only one tab. BUG=674684 Committed: https://crrev.com/2d3fdfb80db5f3c2229c940ebf62286dc7c372b1 Cr-Commit-Position: refs/heads/master@{#438965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Theresa
ptal
4 years ago (2016-12-15 23:25:13 UTC) #2
gone
lgtm
4 years ago (2016-12-15 23:28:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575343003/1
4 years ago (2016-12-15 23:30:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-16 00:23:55 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-16 00:26:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d3fdfb80db5f3c2229c940ebf62286dc7c372b1
Cr-Commit-Position: refs/heads/master@{#438965}

Powered by Google App Engine
This is Rietveld 408576698