Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3472)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 2575343003: Hide the "Move to other window" menu option when there is only one tab (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
index 529b7d689639020b2ce80342b3cf3e6627ce45aa..6d0529a89bc7aecefc991494bf7f4ee2538ba244 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
@@ -136,8 +136,10 @@ public class AppMenuPropertiesDelegate {
menu.findItem(R.id.update_menu_id).setVisible(
UpdateMenuItemHelper.getInstance().shouldShowMenuItem(mActivity));
+ boolean hasMoreThanOneTab = mActivity.getTabModelSelector().getTotalTabCount() > 1;
menu.findItem(R.id.move_to_other_window_menu_id).setVisible(
- MultiWindowUtils.getInstance().isOpenInOtherWindowSupported(mActivity));
+ MultiWindowUtils.getInstance().isOpenInOtherWindowSupported(mActivity)
+ && hasMoreThanOneTab);
MenuItem recentTabsMenuItem = menu.findItem(R.id.recent_tabs_menu_id);
recentTabsMenuItem.setVisible(!isIncognito);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698