Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2575343002: Move logic of WebLocalFrameImpl::replaceSelection to Editor (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chongz, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move logic of WebLocalFrameImpl::replaceSelection to Editor This patch moves the main logic of WebLocalFrameImpl::replaceSelection to Editor, so that the web/ layer becomes thinner, and less details of editing are exposed. No behavior is changed. This patch is also a preparation for https://codereview.chromium.org/2576903002. BUG=673789 Committed: https://crrev.com/7966ad310a110b28e1e398534804266c19e4d09a Cr-Commit-Position: refs/heads/master@{#438757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-15 05:13:01 UTC) #6
tkent
lgtm
4 years ago (2016-12-15 05:15:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2575343002/1
4 years ago (2016-12-15 05:36:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 05:41:03 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-15 05:42:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7966ad310a110b28e1e398534804266c19e4d09a
Cr-Commit-Position: refs/heads/master@{#438757}

Powered by Google App Engine
This is Rietveld 408576698