third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2575343002: Move logic of WebLocalFrameImpl::replaceSelection to Editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2575343002: Move logic of WebLocalFrameImpl::replaceSelection to Editor (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index a8b6dff32a558c7aafaad334ddc44055a9839081..82343babbefba12d7a2245e2b570827981e58a4c 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -1665,6 +1665,14 @@ void Editor::tidyUpHTMLStructure(Document& document) {

// TODO(tkent): Should we check and move Text node children of <html>?

}

+void Editor::replaceSelection(const String& text) {

+ DCHECK(!frame().document()->needsLayoutTreeUpdate());

+ bool selectReplacement = behavior().shouldSelectReplacement();

+ bool smartReplace = true;

+ replaceSelectionWithText(text, selectReplacement, smartReplace,

+ InputEvent::InputType::InsertReplacementText);

DEFINE_TRACE(Editor) {

visitor->trace(m_frame);

visitor->trace(m_lastEditCommand);