Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 2575233003: Record the time when the interstitial is constructed (Closed)

Created:
4 years ago by estark
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Record the time when the interstitial is constructed In Safe Browsing Extended Reporting reports, send the timestamp at which the interstitial was constructed, in addition to the timestamp of the report being sent. This will be helpful in cases where the user fixes the clock while the interstitial is showing (so that we can see the client clock time that actually triggered the date error). BUG=632218 Review-Url: https://codereview.chromium.org/2524903004 Cr-Commit-Position: refs/heads/master@{#434331} (cherry picked from commit 6255265704c19083d47fb1500ee869f872dd546d) Committed: https://chromium.googlesource.com/chromium/src/+/9acee6d2c7c5e3deaa441f2a29e08a660e2860bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M chrome/browser/ssl/bad_clock_blocking_page.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/bad_clock_blocking_page.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/cert_report_helper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ssl/cert_report_helper.cc View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/certificate_reporting/cert_logger.proto View 2 chunks +4 lines, -2 lines 0 comments Download
M components/certificate_reporting/error_report.h View 2 chunks +6 lines, -1 line 0 comments Download
M components/certificate_reporting/error_report.cc View 2 chunks +4 lines, -1 line 0 comments Download
M components/certificate_reporting/error_report_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estark
4 years ago (2016-12-15 01:50:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9acee6d2c7c5e3deaa441f2a29e08a660e2860bc.

Powered by Google App Engine
This is Rietveld 408576698