Record the time when the interstitial is constructed

Record the time when the interstitial is constructed

In Safe Browsing Extended Reporting reports, send the timestamp at which
the interstitial was constructed, in addition to the timestamp of the
report being sent. This will be helpful in cases where the user fixes
the clock while the interstitial is showing (so that we can see the
client clock time that actually triggered the date error).

BUG=632218
Committed: https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d
Cr-Commit-Position: refs/heads/master@{#434331}

[estark, 2016-11-23 21:34:44]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 21:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-11-23 21:41:16]

estark@chromium.org changed reviewers:
+ meacer@chromium.org

[estark, 2016-11-23 21:41:17]

meacer, PTAL?

https://codereview.chromium.org/2524903004/diff/1/chrome/browser/ssl/bad_cloc...
File chrome/browser/ssl/bad_clock_blocking_page.h (left):

https://codereview.chromium.org/2524903004/diff/1/chrome/browser/ssl/bad_cloc...
chrome/browser/ssl/bad_clock_blocking_page.h:74: const base::Time
time_triggered_;
This was unused AFAICT so I cleaned it up as a drive-by

[meacer, 2016-11-23 23:27:49]

Lgtm

https://codereview.chromium.org/2524903004/diff/1/chrome/browser/ssl/bad_cloc...
File chrome/browser/ssl/bad_clock_blocking_page.h (left):

https://codereview.chromium.org/2524903004/diff/1/chrome/browser/ssl/bad_cloc...
chrome/browser/ssl/bad_clock_blocking_page.h:74: const base::Time
time_triggered_;
On 2016/11/23 21:41:17, estark wrote:
> This was unused AFAICT so I cleaned it up as a drive-by

Looks like we should also get rid of ssl_info_ and make CertReportHelper expose
it as a protected field. No need to do it here though.

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
File components/certificate_reporting/cert_logger.proto (right):

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/cert_logger.proto:45: // The time (in usec
since the epoch) when the client created the
nit: Maybe note which epoch this is (unix).

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/cert_logger.proto:46: // interstiital.
spelling

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/cert_logger.proto:47: optional int64
interstitial_time_usec = 4;
Very minor nit: Perhaps rename to interstitial_created_time_usec? Or is it too
long?

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
File components/certificate_reporting/error_report_unittest.cc (right):

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/error_report_unittest.cc:131: base::Time
interstitial_time = base::Time::Now();
nit: const

[commit-bot: I haz the power, 2016-11-23 23:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 23:37:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[estark, 2016-11-24 00:00:08]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[estark, 2016-11-24 00:00:17]

Thanks!

https://codereview.chromium.org/2524903004/diff/1/chrome/browser/ssl/bad_cloc...
File chrome/browser/ssl/bad_clock_blocking_page.h (left):

https://codereview.chromium.org/2524903004/diff/1/chrome/browser/ssl/bad_cloc...
chrome/browser/ssl/bad_clock_blocking_page.h:74: const base::Time
time_triggered_;
On 2016/11/23 23:27:48, Mustafa Emre Acer wrote:
> On 2016/11/23 21:41:17, estark wrote:
> > This was unused AFAICT so I cleaned it up as a drive-by
> 
> Looks like we should also get rid of ssl_info_ and make CertReportHelper
expose
> it as a protected field. No need to do it here though.

Acknowledged.

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
File components/certificate_reporting/cert_logger.proto (right):

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/cert_logger.proto:45: // The time (in usec
since the epoch) when the client created the
On 2016/11/23 23:27:48, Mustafa Emre Acer wrote:
> nit: Maybe note which epoch this is (unix).

Done (it's actually windows epoch, unfortunately)

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/cert_logger.proto:46: // interstiital.
On 2016/11/23 23:27:49, Mustafa Emre Acer wrote:
> spelling

Done.

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/cert_logger.proto:47: optional int64
interstitial_time_usec = 4;
On 2016/11/23 23:27:49, Mustafa Emre Acer wrote:
> Very minor nit: Perhaps rename to interstitial_created_time_usec? Or is it too
> long?

Done.

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
File components/certificate_reporting/error_report_unittest.cc (right):

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/error_report_unittest.cc:131: base::Time
interstitial_time = base::Time::Now();
On 2016/11/23 23:27:49, Mustafa Emre Acer wrote:
> nit: const

Done.

[commit-bot: I haz the power, 2016-11-24 00:00:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-11-24 00:02:25]

The CQ bit was unchecked by estark@chromium.org

[estark, 2016-11-24 00:02:51]

The CQ bit was checked by estark@chromium.org

[estark, 2016-11-24 00:02:51]

The patchset sent to the CQ was uploaded after l-g-t-m from meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2524903004/#ps20001
(title: "meacer comments")

[commit-bot: I haz the power, 2016-11-24 00:03:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[meacer, 2016-11-24 00:23:46]

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
File components/certificate_reporting/cert_logger.proto (right):

https://codereview.chromium.org/2524903004/diff/1/components/certificate_repo...
components/certificate_reporting/cert_logger.proto:45: // The time (in usec
since the epoch) when the client created the
On 2016/11/24 00:00:16, estark wrote:
> On 2016/11/23 23:27:48, Mustafa Emre Acer wrote:
> > nit: Maybe note which epoch this is (unix).
> 
> Done (it's actually windows epoch, unfortunately)

Yeah, I remembered this quirk after hitting send. Too late.

[commit-bot: I haz the power, 2016-11-24 02:03:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:03:54]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[estark, 2016-11-24 03:04:05]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-11-24 03:04:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 04:47:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 04:47:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estark, 2016-11-24 06:58:00]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-11-24 06:58:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 08:59:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 08:59:38]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[estark, 2016-11-24 15:29:37]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-11-24 15:30:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 15:44:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480001377783110,
"parent_rev": "e39bdbcb05d8e4678911f0622833e87773b74a1a", "commit_rev":
"dc3bd9780d3ec1cbd071f976ecac3bb9d31cafc7"}

[commit-bot: I haz the power, 2016-11-24 15:45:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-24 15:48:33]

Description was changed from

==========
Record the time when the interstitial is constructed

In Safe Browsing Extended Reporting reports, send the timestamp at which
the interstitial was constructed, in addition to the timestamp of the
report being sent. This will be helpful in cases where the user fixes
the clock while the interstitial is showing (so that we can see the
client clock time that actually triggered the date error).

BUG=632218
==========

to

==========
Record the time when the interstitial is constructed

In Safe Browsing Extended Reporting reports, send the timestamp at which
the interstitial was constructed, in addition to the timestamp of the
report being sent. This will be helpful in cases where the user fixes
the clock while the interstitial is showing (so that we can see the
client clock time that actually triggered the date error).

BUG=632218

Committed: https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d
Cr-Commit-Position: refs/heads/master@{#434331}
==========

[commit-bot: I haz the power, 2016-11-24 15:48:34]

Patchset 2 (id:??) landed as
https://crrev.com/6255265704c19083d47fb1500ee869f872dd546d
Cr-Commit-Position: refs/heads/master@{#434331}