Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5943)

Unified Diff: chrome/browser/ssl/cert_report_helper.cc

Issue 2575233003: Record the time when the interstitial is constructed (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/cert_report_helper.h ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/cert_report_helper.cc
diff --git a/chrome/browser/ssl/cert_report_helper.cc b/chrome/browser/ssl/cert_report_helper.cc
index e4d77ad3207356d1f3afcca5cb2da5430f8709a1..1c41bb4820754df112a5a5fd3476426bbaae7677 100644
--- a/chrome/browser/ssl/cert_report_helper.cc
+++ b/chrome/browser/ssl/cert_report_helper.cc
@@ -51,6 +51,7 @@ CertReportHelper::CertReportHelper(
const net::SSLInfo& ssl_info,
certificate_reporting::ErrorReport::InterstitialReason interstitial_reason,
bool overridable,
+ const base::Time& interstitial_time,
security_interstitials::MetricsHelper* metrics_helper)
: ssl_cert_reporter_(std::move(ssl_cert_reporter)),
web_contents_(web_contents),
@@ -58,6 +59,7 @@ CertReportHelper::CertReportHelper(
ssl_info_(ssl_info),
interstitial_reason_(interstitial_reason),
overridable_(overridable),
+ interstitial_time_(interstitial_time),
metrics_helper_(metrics_helper) {}
CertReportHelper::~CertReportHelper() {
@@ -118,7 +120,8 @@ void CertReportHelper::FinishCertCollection(
interstitial_reason_, user_proceeded,
overridable_
? certificate_reporting::ErrorReport::INTERSTITIAL_OVERRIDABLE
- : certificate_reporting::ErrorReport::INTERSTITIAL_NOT_OVERRIDABLE);
+ : certificate_reporting::ErrorReport::INTERSTITIAL_NOT_OVERRIDABLE,
+ interstitial_time_);
if (!report.Serialize(&serialized_report)) {
LOG(ERROR) << "Failed to serialize certificate report.";
« no previous file with comments | « chrome/browser/ssl/cert_report_helper.h ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698