Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2574963002:
Remove an entry for associatedFormControls-leak-nodes.html. (Closed)
DescriptionRemove an entry for associatedFormControls-leak-nodes.html.
Looks like a clang roll caused a failure, and the roll was reverted.
BUG=673463
TBR=asargent@chromium.org, thakis@chromium.org
NOTRY=true
Committed: https://crrev.com/206ae7f05c22113462df0364b5d8b8c8cfccfc2a
Cr-Commit-Position: refs/heads/master@{#438411}
Patch Set 1 #
Messages
Total messages: 17 (5 generated)
Description was changed from ========== Remove an entry for associatedFormControls-leak-nodes.html. Looks like a clang roll caused a failure, and the roll was reverted. BUG=673463 TBR=asargent@chromium.org, thakis@chromium.org ========== to ========== Remove an entry for associatedFormControls-leak-nodes.html. Looks like a clang roll caused a failure, and the roll was reverted. BUG=673463 TBR=asargent@chromium.org, thakis@chromium.org NOTRY=true ==========
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481685443215440, "parent_rev":
"8f0a3bbaef9e4fd1d39b38d1b92fb8c01f25e282", "commit_rev":
"54591aeddedc9fa84703320a83b0fff45082398b"}
Message was sent while issue was closed.
Description was changed from ========== Remove an entry for associatedFormControls-leak-nodes.html. Looks like a clang roll caused a failure, and the roll was reverted. BUG=673463 TBR=asargent@chromium.org, thakis@chromium.org NOTRY=true ========== to ========== Remove an entry for associatedFormControls-leak-nodes.html. Looks like a clang roll caused a failure, and the roll was reverted. BUG=673463 TBR=asargent@chromium.org, thakis@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2574963002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove an entry for associatedFormControls-leak-nodes.html. Looks like a clang roll caused a failure, and the roll was reverted. BUG=673463 TBR=asargent@chromium.org, thakis@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2574963002 ========== to ========== Remove an entry for associatedFormControls-leak-nodes.html. Looks like a clang roll caused a failure, and the roll was reverted. BUG=673463 TBR=asargent@chromium.org, thakis@chromium.org NOTRY=true Committed: https://crrev.com/206ae7f05c22113462df0364b5d8b8c8cfccfc2a Cr-Commit-Position: refs/heads/master@{#438411} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/206ae7f05c22113462df0364b5d8b8c8cfccfc2a Cr-Commit-Position: refs/heads/master@{#438411}
Message was sent while issue was closed.
That test is failing on some cq bots now: https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/... This should probably be reverted?
Message was sent while issue was closed.
Oh, and the clang roll is relanding. https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot doesn't have any redness about this and nobody cc'd me on the bug, so we didn't know about it.
Message was sent while issue was closed.
On 2016/12/14 15:18:41, Nico wrote: > Oh, and the clang roll is relanding. > https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot doesn't > have any redness about this and nobody cc'd me on the bug, so we didn't know > about it. (and the test also fails on the try without that clang roll, so I don't think it's due to the clang roll)
Message was sent while issue was closed.
On 2016/12/14 15:19:02, Nico wrote: > On 2016/12/14 15:18:41, Nico wrote: > > Oh, and the clang roll is relanding. > > https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot doesn't > > have any redness about this and nobody cc'd me on the bug, so we didn't know > > about it. > > (and the test also fails on the try without that clang roll, so I don't think > it's due to the clang roll) (on the retry, that is)
Message was sent while issue was closed.
(Finally, https://codereview.chromium.org/1965753002 suggests to me that while the clang roll might trigger this, it feels more likely that there's a bug either in the test or in the code that it tests.) On Wed, Dec 14, 2016 at 10:19 AM, <thakis@chromium.org> wrote: > On 2016/12/14 15:19:02, Nico wrote: > > On 2016/12/14 15:18:41, Nico wrote: > > > Oh, and the clang roll is relanding. > > > https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot > doesn't > > > have any redness about this and nobody cc'd me on the bug, so we > didn't know > > > about it. > > > > (and the test also fails on the try without that clang roll, so I don't > think > > it's due to the clang roll) > > (on the retry, that is) > > https://codereview.chromium.org/2574963002/ > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
(Finally, https://codereview.chromium.org/1965753002 suggests to me that while the clang roll might trigger this, it feels more likely that there's a bug either in the test or in the code that it tests.) On Wed, Dec 14, 2016 at 10:19 AM, <thakis@chromium.org> wrote: > On 2016/12/14 15:19:02, Nico wrote: > > On 2016/12/14 15:18:41, Nico wrote: > > > Oh, and the clang roll is relanding. > > > https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot > doesn't > > > have any redness about this and nobody cc'd me on the bug, so we > didn't know > > > about it. > > > > (and the test also fails on the try without that clang roll, so I don't > think > > it's due to the clang roll) > > (on the retry, that is) > > https://codereview.chromium.org/2574963002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
https://codereview.chromium.org/2569763006/ seems to keep the test passing even after the clang roll. On Wed, Dec 14, 2016 at 12:54 PM, Nico Weber <thakis@chromium.org> wrote: > (Finally, https://codereview.chromium.org/1965753002 suggests to me that > while the clang roll might trigger this, it feels more likely that there's > a bug either in the test or in the code that it tests.) > > On Wed, Dec 14, 2016 at 10:19 AM, <thakis@chromium.org> wrote: > >> On 2016/12/14 15:19:02, Nico wrote: >> > On 2016/12/14 15:18:41, Nico wrote: >> > > Oh, and the clang roll is relanding. >> > > https://build.chromium.org/p/chromium.fyi/console?category=c >> lang%20tot >> doesn't >> > > have any redness about this and nobody cc'd me on the bug, so we >> didn't know >> > > about it. >> > >> > (and the test also fails on the try without that clang roll, so I don't >> think >> > it's due to the clang roll) >> >> (on the retry, that is) >> >> https://codereview.chromium.org/2574963002/ >> > > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
https://codereview.chromium.org/2569763006/ seems to keep the test passing even after the clang roll. On Wed, Dec 14, 2016 at 12:54 PM, Nico Weber <thakis@chromium.org> wrote: > (Finally, https://codereview.chromium.org/1965753002 suggests to me that > while the clang roll might trigger this, it feels more likely that there's > a bug either in the test or in the code that it tests.) > > On Wed, Dec 14, 2016 at 10:19 AM, <thakis@chromium.org> wrote: > >> On 2016/12/14 15:19:02, Nico wrote: >> > On 2016/12/14 15:18:41, Nico wrote: >> > > Oh, and the clang roll is relanding. >> > > https://build.chromium.org/p/chromium.fyi/console?category=c >> lang%20tot >> doesn't >> > > have any redness about this and nobody cc'd me on the bug, so we >> didn't know >> > > about it. >> > >> > (and the test also fails on the try without that clang roll, so I don't >> think >> > it's due to the clang roll) >> >> (on the retry, that is) >> >> https://codereview.chromium.org/2574963002/ >> > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
