Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1965753002: Try running GC twice to fix flaky associatedFormControls-leak-nodes.html (Closed)

Created:
4 years, 7 months ago by keishi
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try running GC twice to fix flaky associatedFormControls-leak-nodes.html When the test passes documentsBefore=2 and documentsAfter=1 Sometimes this test is faling because documentsBefore=3 and documentsAfter=1 BUG=585328 Committed: https://crrev.com/3f757a9e9024f151a0dffea5df05ebbf33630755 Cr-Commit-Position: refs/heads/master@{#392903}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/associatedFormControls-leak-nodes.html View 1 chunk +13 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
keishi
I changed asyncGC to run GCs until there is no more garbage in https://codereview.chromium.org/1915003002/ but ...
4 years, 7 months ago (2016-05-10 12:28:47 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-10 13:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965753002/1
4 years, 7 months ago (2016-05-11 02:26:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/226832)
4 years, 7 months ago (2016-05-11 04:08:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965753002/20001
4 years, 7 months ago (2016-05-11 05:06:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/3558) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-11 05:08:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1965753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1965753002/40001
4 years, 7 months ago (2016-05-11 11:42:37 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-11 12:45:00 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 12:46:23 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f757a9e9024f151a0dffea5df05ebbf33630755
Cr-Commit-Position: refs/heads/master@{#392903}

Powered by Google App Engine
This is Rietveld 408576698