Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2574833002: ES6 style: fix some nits from phistuck@ on chromium-dev@ (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ES6 style: fix some nits from phistuck@ on chromium-dev@ R=dpapad@chromium.org BUG=671426 NOTRY=true Committed: https://crrev.com/c5454c2f5a6a18a6bb4ee57c57f0f842e5179f95 Cr-Commit-Position: refs/heads/master@{#438289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M docs/es6_chromium.md View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Dan Beam
4 years ago (2016-12-13 19:24:44 UTC) #1
dpapad
lgtm
4 years ago (2016-12-13 19:54:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574833002/1
4 years ago (2016-12-13 21:12:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 21:43:53 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-13 21:46:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5454c2f5a6a18a6bb4ee57c57f0f842e5179f95
Cr-Commit-Position: refs/heads/master@{#438289}

Powered by Google App Engine
This is Rietveld 408576698