Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: docs/es6_chromium.md

Issue 2574833002: ES6 style: fix some nits from phistuck@ on chromium-dev@ (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/es6_chromium.md
diff --git a/docs/es6_chromium.md b/docs/es6_chromium.md
index 055edc69b3f86605e8d85a0c24cd7261c55cd043..e9dc7c89afbeeba40836d0a5f55a6f8b08934df4 100644
--- a/docs/es6_chromium.md
+++ b/docs/es6_chromium.md
@@ -132,7 +132,7 @@ var fullyLoaded = new Promise(function(resolve) {
});
// ... some time later ...
-loaded.then(startTheApp).then(maybeShowFirstRun);
+fullyLoaded.then(startTheApp).then(maybeShowFirstRun);
```
**Documentation:** [link](http://www.ecma-international.org/ecma-262/6.0/#sec-promise-objects)
@@ -636,13 +636,17 @@ for (var n of fibonacci) {
```js
// Object.assign
-var o = Object.assign({a:true}, {b:true}, {c:true});
+var o = Object.assign({a:true}, {b:true}, {c:true}); // {a: true, b: true, c: true}
'a' in o && 'b' in o && 'c' in o; // true
// Object.setPrototypeOf
Object.setPrototypeOf({}, Array.prototype) instanceof Array; // true
// Object.is
+Object.is(null, null) // true
+Object.is(NaN, NaN) // true
+Object.is(-0, +0) // false, btw: -0 === +0 is true
+
// Object.getOwnPropertySymbols
```
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698