Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox calculations.

Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox calculations.

BUG=673530
Committed: https://crrev.com/6ebd14abf5556e940f556b04411cf95937bfb74a
Cr-Commit-Position: refs/heads/master@{#438654}

[lgarron, 2016-12-13 21:29:56]

lgarron@chromium.org changed reviewers:
+ estark@chromium.org

[lgarron, 2016-12-13 21:29:57]

estark@, what do you think of this?

I'd like to start paying down technical debt for security UI by placing security
calculations into a central place. A security_state_ui file with an initial
static method looks like the most straightforward to me, but I'm open to other
things, especially if we want to push the decisions into an embedder-specific
layer.

[estark, 2016-12-13 21:47:17]

lgtm

[lgarron, 2016-12-14 01:30:58]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:32:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:57:06]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[lgarron, 2016-12-14 20:14:22]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2016-12-14 20:15:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-12-14 20:18:04]

https://codereview.chromium.org/2574733003/diff/40001/components/security_sta...
File components/security_state/core/security_state_ui.cc (right):

https://codereview.chromium.org/2574733003/diff/40001/components/security_sta...
components/security_state/core/security_state_ui.cc:22: }
you'll need to add

NOTREACHED();
return false;

at the end to get this to compile
(https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy...)

While I'm here, a tiny nit: pronouns in comments are sometimes discouraged, so
I'd recommend dropping the "we" to make it "Enumerate all..."

[lgarron, 2016-12-14 20:28:38]

The CQ bit was checked by lgarron@chromium.org

[lgarron, 2016-12-14 20:28:38]

The patchset sent to the CQ was uploaded after l-g-t-m from estark@chromium.org
Link to the patchset: https://codereview.chromium.org/2574733003/#ps60001
(title: "Fix code and add comment.")

[commit-bot: I haz the power, 2016-12-14 20:29:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lgarron, 2016-12-14 22:18:15]

https://codereview.chromium.org/2574733003/diff/40001/components/security_sta...
File components/security_state/core/security_state_ui.cc (right):

https://codereview.chromium.org/2574733003/diff/40001/components/security_sta...
components/security_state/core/security_state_ui.cc:22: }
On 2016/12/14 at 20:18:04, estark wrote:
> you'll need to add
> 
> NOTREACHED();
> return false;
> 
> at the end to get this to compile
(https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy...)
> 
> While I'm here, a tiny nit: pronouns in comments are sometimes discouraged, so
I'd recommend dropping the "we" to make it "Enumerate all..."

Thanks; done and done.

[commit-bot: I haz the power, 2016-12-14 22:39:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481747318442070,
"parent_rev": "0e0843dce6a5b85f123c7e21aeae606620f6f3a0", "commit_rev":
"ad692c72874e74b06eadbca4e43cf6ea97cffadf"}

[commit-bot: I haz the power, 2016-12-14 22:39:39]

Description was changed from

==========
Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox
calculations.

BUG=673530
==========

to

==========
Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox
calculations.

BUG=673530

Review-Url: https://codereview.chromium.org/2574733003
==========

[commit-bot: I haz the power, 2016-12-14 22:39:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 22:42:05]

Description was changed from

==========
Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox
calculations.

BUG=673530

Review-Url: https://codereview.chromium.org/2574733003
==========

to

==========
Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox
calculations.

BUG=673530

Committed: https://crrev.com/6ebd14abf5556e940f556b04411cf95937bfb74a
Cr-Commit-Position: refs/heads/master@{#438654}
==========

[commit-bot: I haz the power, 2016-12-14 22:42:06]

Patchset 4 (id:??) landed as
https://crrev.com/6ebd14abf5556e940f556b04411cf95937bfb74a
Cr-Commit-Position: refs/heads/master@{#438654}