Introduce security_state::ShouldAlwaysShowIcon() for mobile omnibox calculations.

components/security_state/core/security_state_ui.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/security_state/core/security_state_ui.h"
+
+namespace security_state {
+
+bool ShouldAlwaysShowIcon(SecurityLevel security_level) {
+  // We enumerate all |SecurityLevel| values for compile-time enforcement that
+  // all cases are explicitly handled.
+  switch (security_level) {
+    case NONE:
+      return false;
+    case HTTP_SHOW_WARNING:
+    case EV_SECURE:
+    case SECURE:
+    case SECURITY_WARNING:
+    case SECURE_WITH_POLICY_INSTALLED_CERT:
+    case DANGEROUS:
+      return true;
+  }

[estark, 2016/12/14 20:18:04]

you'll need to add

NOTREACHED();
return false;

at the end to get this to compile
(https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy...)

While I'm here, a tiny nit: pronouns in comments are sometimes discouraged, so
I'd recommend dropping the "we" to make it "Enumerate all..."

[lgarron, 2016/12/14 22:18:15]

Thanks; done and done.

+}
+
+}  // namespace security_state