Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issue 2574703002: Use ParentFrameTaskRunners in WorkerLoaderProxyProvider::postTaskToLoader impls (Closed)

Created:
4 years ago by tzik
Modified:
4 years ago
Reviewers:
haraken, nhiroki, yhirano
CC:
chromium-reviews, kinuko+worker_chromium.org, tyoshino+watch_chromium.org, shimazu+worker_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, Nate Chapin, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ParentFrameTaskRunners in WorkerLoaderProxyProvider::postTaskToLoader impls Implementations of WorkerLoaderProxyProvider::postTaskToLoader have used ExecutionContext::postTask to post tasks to the main thread. However, the posted tasks are unexpectedly throttled, and that delays the startup time of service workers. This CL replaces ExecutionContext::postTask there with ParentFrameTaskRunners and WebTaskRunner::postTask, so that the posted task is routed to suitable task runners. BUG=667310, 671084 Committed: https://crrev.com/200baa21d49f1a2688a33bb64f4b689fdae69119 Cr-Commit-Position: refs/heads/master@{#438146}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M third_party/WebKit/Source/core/dom/ExecutionContextTask.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp View 1 3 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp View 1 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
tzik
PTAL
4 years ago (2016-12-13 10:43:14 UTC) #9
nhiroki
LGTM. Thank you for working on this :)
4 years ago (2016-12-13 11:16:14 UTC) #11
tzik
+haraken & yhirano for OWNER review. PTAL.
4 years ago (2016-12-13 11:17:30 UTC) #14
haraken
LGTM
4 years ago (2016-12-13 11:27:22 UTC) #15
yhirano
lgtm
4 years ago (2016-12-13 12:26:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574703002/20001
4 years ago (2016-12-13 12:55:01 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 13:00:15 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-13 13:02:47 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/200baa21d49f1a2688a33bb64f4b689fdae69119
Cr-Commit-Position: refs/heads/master@{#438146}

Powered by Google App Engine
This is Rietveld 408576698