third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp - Issue 2574703002: Use ParentFrameTaskRunners in WorkerLoaderProxyProvider::postTaskToLoader impls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp

Issue 2574703002: Use ParentFrameTaskRunners in WorkerLoaderProxyProvider::postTaskToLoader impls (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp

diff --git a/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp b/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp

index 897f5de67684a0f0d75ae81c19c0e6a1faa88568..d08013b0705bd07675c7fafcd6fe623ba90dcae1 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp

+++ b/third_party/WebKit/Source/core/workers/ThreadedMessagingProxyBase.cpp

@@ -74,9 +74,12 @@ void ThreadedMessagingProxyBase::postTaskToLoader(

const WebTraceLocation& location,

std::unique_ptr<ExecutionContextTask> task) {

DCHECK(getExecutionContext()->isDocument());

- // TODO(hiroshige,yuryu): Make this not use ExecutionContextTask and use

- // m_parentFrameTaskRunners->get(TaskType::Networking) instead.

- getExecutionContext()->postTask(location, std::move(task));

+ m_parentFrameTaskRunners->get(TaskType::Networking)

+ ->postTask(BLINK_FROM_HERE,

+ crossThreadBind(

+ &ExecutionContextTask::performTaskIfContextIsValid,

+ WTF::passed(std::move(task)),

+ wrapCrossThreadWeakPersistent(getExecutionContext())));

}

void ThreadedMessagingProxyBase::countFeature(UseCounter::Feature feature) {