Issue 257453003: Some code cleanup, esp. includes and copyright headers.

Issue 257453003: Some code cleanup, esp. includes and copyright headers. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Some code cleanup, esp. includes and copyright headers. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20938

Patch Set 2 : REBASE #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -551 lines)			Patch
M	src/arm/constants-arm.h	View		1 chunk	+6 lines, -26 lines	0 comments	Download
M	src/arm/constants-arm.cc	View		1 chunk	+3 lines, -26 lines	0 comments	Download
M	src/arm64/constants-arm64.h	View		2 chunks	+9 lines, -33 lines	0 comments	Download
M	src/disassembler.h	View		1 chunk	+9 lines, -26 lines	0 comments	Download
M	src/disassembler.cc	View		2 chunks	+11 lines, -31 lines	0 comments	Download
M	src/ic.h	View		3 chunks	+3 lines, -28 lines	0 comments	Download
M	src/ic.cc	View		2 chunks	+5 lines, -30 lines	0 comments	Download
M	src/ic-inl.h	View		3 chunks	+3 lines, -29 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+3 lines, -26 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+6 lines, -30 lines	0 comments	Download
M	src/objects-debug.cc	View		1 chunk	+3 lines, -29 lines	0 comments	Download
M	src/objects-inl.h	View	1	2 chunks	+15 lines, -39 lines	0 comments	Download
M	src/objects-printer.cc	View		1 chunk	+3 lines, -29 lines	0 comments	Download
M	src/objects-visiting.h	View		2 chunks	+5 lines, -28 lines	0 comments	Download
M	src/objects-visiting.cc	View		1 chunk	+6 lines, -29 lines	0 comments	Download
M	src/objects-visiting-inl.h	View		2 chunks	+4 lines, -27 lines	0 comments	Download
M	src/zone.h	View		2 chunks	+3 lines, -27 lines	0 comments	Download
M	src/zone.cc	View		3 chunks	+7 lines, -30 lines	0 comments	Download
M	src/zone-inl.h	View		4 chunks	+4 lines, -28 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit. https://codereview.chromium.org/257453003/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/257453003/diff/1/src/objects-inl.h#newcode50 src/objects-inl.h:50: // code. gcc is not ...

6 years, 8 months ago (2014-04-24 11:17:21 UTC) #2

Benedikt Meurer

https://codereview.chromium.org/257453003/diff/1/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/257453003/diff/1/src/objects-inl.h#newcode50 src/objects-inl.h:50: // code. gcc is not happy when attempting to ...

6 years, 8 months ago (2014-04-24 11:30:50 UTC) #3

Benedikt Meurer

6 years, 8 months ago (2014-04-24 11:33:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20938 (presubmit successful).

Expand Messages | Collapse Messages