Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one
MemoryAllocatorDump for each cache entry. To make the memory dump lighter,
this CL dumps the total size and count and does not create sub dumps.

BUG=669108
Committed: https://crrev.com/3c8373a83964c182d3cab8ca42a22d8493d3931c
Cr-Commit-Position: refs/heads/master@{#437981}

[xunjieli, 2016-12-12 20:13:32]

Description was changed from

==========
Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one MemoryAllocatorDump for
each cache entry. To make memory dump light, we should dump the total size and
count and not create sub dumps.

BUG=669108
==========

to

==========
Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one 
MemoryAllocatorDump for each cache entry. To make the memory dump lighter, 
this CL dumps the total size and count and does not create sub dumps.

BUG=669108
==========

[xunjieli, 2016-12-12 20:13:32]

xunjieli@chromium.org changed reviewers:
+ ssid@chromium.org

[ssid, 2016-12-12 20:25:24]

Thanks for fixing this. lgtm % the unittest comment.

https://codereview.chromium.org/2574513002/diff/1/net/ssl/ssl_client_session_...
File net/ssl/ssl_client_session_cache_unittest.cc (right):

https://codereview.chromium.org/2574513002/diff/1/net/ssl/ssl_client_session_...
net/ssl/ssl_client_session_cache_unittest.cc:330: allocator_dumps =
process_memory_dump->allocator_dumps();
You do not need to iterate through the list of dumps here. Can you just use
pmd->GetAllocatorDump("net/ssl_session_cache"), or am I missing something?

[xunjieli, 2016-12-12 20:49:04]

Thanks!

https://codereview.chromium.org/2574513002/diff/1/net/ssl/ssl_client_session_...
File net/ssl/ssl_client_session_cache_unittest.cc (right):

https://codereview.chromium.org/2574513002/diff/1/net/ssl/ssl_client_session_...
net/ssl/ssl_client_session_cache_unittest.cc:330: allocator_dumps =
process_memory_dump->allocator_dumps();
On 2016/12/12 20:25:24, ssid wrote:
> You do not need to iterate through the list of dumps here. Can you just use
> pmd->GetAllocatorDump("net/ssl_session_cache"), or am I missing something?

Done.

[xunjieli, 2016-12-12 20:49:10]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-12-12 20:49:10]

The patchset sent to the CQ was uploaded after l-g-t-m from ssid@chromium.org
Link to the patchset: https://codereview.chromium.org/2574513002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-12-12 20:50:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 01:49:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481575750423150,
"parent_rev": "7952fbd460ca354119d098ef5a217d1e70d9b93a", "commit_rev":
"d6528762ef6e0e97857b11f51548735997401f79"}

[commit-bot: I haz the power, 2016-12-13 01:50:26]

Description was changed from

==========
Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one 
MemoryAllocatorDump for each cache entry. To make the memory dump lighter, 
this CL dumps the total size and count and does not create sub dumps.

BUG=669108
==========

to

==========
Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one 
MemoryAllocatorDump for each cache entry. To make the memory dump lighter, 
this CL dumps the total size and count and does not create sub dumps.

BUG=669108

Review-Url: https://codereview.chromium.org/2574513002
==========

[commit-bot: I haz the power, 2016-12-13 01:50:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 01:52:26]

Description was changed from

==========
Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one 
MemoryAllocatorDump for each cache entry. To make the memory dump lighter, 
this CL dumps the total size and count and does not create sub dumps.

BUG=669108

Review-Url: https://codereview.chromium.org/2574513002
==========

to

==========
Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

SSLClientSessionCache::DumpMemoryStats() creates one
MemoryAllocatorDump for each cache entry. To make the memory dump lighter,
this CL dumps the total size and count and does not create sub dumps.

BUG=669108

Committed: https://crrev.com/3c8373a83964c182d3cab8ca42a22d8493d3931c
Cr-Commit-Position: refs/heads/master@{#437981}
==========

[commit-bot: I haz the power, 2016-12-13 01:52:27]

Patchset 2 (id:??) landed as
https://crrev.com/3c8373a83964c182d3cab8ca42a22d8493d3931c
Cr-Commit-Position: refs/heads/master@{#437981}