Do not create sub MemoryAllocatorDumps in SSLClientSessionCache

net/ssl/ssl_client_session_cache_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ssl/ssl_client_session_cache.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/test/simple_test_clock.h"
 #include "base/time/time.h"
 #include "base/trace_event/memory_allocator_dump.h"
 #include "base/trace_event/process_memory_dump.h"
+#include "base/trace_event/trace_event_argument.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/boringssl/src/include/openssl/ssl.h"
 
 namespace net {
 
 namespace {
 
 std::unique_ptr<base::SimpleTestClock> MakeTestClock() {
   std::unique_ptr<base::SimpleTestClock> clock =
       base::MakeUnique<base::SimpleTestClock>();
@@ skipping 295 matching lines @@
   EXPECT_EQ(session3.get(), cache.Lookup("key3").get());
   EXPECT_EQ(3u, cache.size());
 
   base::trace_event::MemoryDumpArgs dump_args = {
       base::trace_event::MemoryDumpLevelOfDetail::DETAILED};
   std::unique_ptr<base::trace_event::ProcessMemoryDump> process_memory_dump(
       new base::trace_event::ProcessMemoryDump(nullptr, dump_args));
   cache.DumpMemoryStats(process_memory_dump.get());
 
   const base::trace_event::ProcessMemoryDump::AllocatorDumpsMap&
       allocator_dumps = process_memory_dump->allocator_dumps();

[ssid, 2016/12/12 20:25:24]

You do not need to iterate through the list of dumps here. Can you just use
pmd->GetAllocatorDump("net/ssl_session_cache"), or am I missing something?

[xunjieli, 2016/12/12 20:49:03]

Done.

 
-  size_t num_entry_dump = 0;
+  bool did_dump = false;
   for (const auto& pair : allocator_dumps) {
     const std::string& dump_name = pair.first;
-    if (dump_name.find("net/ssl_session_cache/entry") != std::string::npos)
-      num_entry_dump++;
+    if (dump_name.find("net/ssl_session_cache") != std::string::npos) {
+      std::unique_ptr<base::Value> raw_attrs =
+          pair.second->attributes_for_testing()->ToBaseValue();
+      base::DictionaryValue* attrs;
+      ASSERT_TRUE(raw_attrs->GetAsDictionary(&attrs));
+      ASSERT_TRUE(attrs->HasKey("cert_count"));
+      ASSERT_TRUE(attrs->HasKey("serialized_cert_size"));
+      ASSERT_TRUE(
+          attrs->HasKey(base::trace_event::MemoryAllocatorDump::kNameSize));
+      did_dump = true;
+    }
   }
-  ASSERT_EQ(3u, num_entry_dump);
+  ASSERT_TRUE(did_dump);
 }
 
 }  // namespace net