Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2574483002: Revert of [Telemetry] Add temporary logging to desktop_browser_finder (Closed)

Created:
4 years ago by eakuefner
Modified:
4 years ago
Reviewers:
sullivan, nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Add temporary logging to desktop_browser_finder (patchset #1 id:1 of https://codereview.chromium.org/2567783002/ ) Reason for revert: No longer needed; root cause diagnosed. Original issue's description: > [Telemetry] Add temporary logging to desktop_browser_finder > > We've seen scenarios where DesktopBrowserFinder unit tests fail because > sys.platform reports a wrong platform, presumably due to being stubbed out too > aggressively by system_stub. This CL adds some temporary logging to make sure > that the reason browsers sometimes can't be found on the Catapult CQ is due to > this stubbing problem. > > BUG=catapult:#3074 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2567783002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/707aaac64b3c0a86d253e1ab502e73996d63927e TBR=sullivan@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=catapult:#3074 Review-Url: https://codereview.chromium.org/2574483002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/60a406396e81bc09500e854916c51657972ad033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
eakuefner
Created Revert of [Telemetry] Add temporary logging to desktop_browser_finder
4 years ago (2016-12-12 19:13:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574483002/1
4 years ago (2016-12-12 19:13:11 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-12 20:11:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698