Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2567783002: [Telemetry] Add temporary logging to desktop_browser_finder (Closed)

Created:
4 years ago by eakuefner
Modified:
4 years ago
Reviewers:
sullivan, nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Add temporary logging to desktop_browser_finder We've seen scenarios where DesktopBrowserFinder unit tests fail because sys.platform reports a wrong platform, presumably due to being stubbed out too aggressively by system_stub. This CL adds some temporary logging to make sure that the reason browsers sometimes can't be found on the Catapult CQ is due to this stubbing problem. BUG=catapult:#3074 NOTRY=true Review-Url: https://codereview.chromium.org/2567783002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/707aaac64b3c0a86d253e1ab502e73996d63927e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
eakuefner
PTAL. NOTRY because I don't want to deal with the flake.
4 years ago (2016-12-09 20:07:01 UTC) #2
nednguyen
lgtm
4 years ago (2016-12-09 20:08:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567783002/1
4 years ago (2016-12-09 20:08:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/707aaac64b3c0a86d253e1ab502e73996d63927e
4 years ago (2016-12-09 20:10:15 UTC) #8
eakuefner
4 years ago (2016-12-12 19:13:04 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2574483002/ by eakuefner@chromium.org.

The reason for reverting is: No longer needed; root cause diagnosed..

Powered by Google App Engine
This is Rietveld 408576698