Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2574463002: [ObjC ARC] Converts ios/chrome/browser/infobars:infobars to ARC.\n\nAutomatically generated ARCMigr… (Closed)

Created:
4 years ago by stkhapugin
Modified:
4 years ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, pkl (ping after 24h if needed), vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/infobars:infobars to ARC. Semi-automatically generated ARCMigrate commit Notable issues:Had to fix includes and subclasses. BUG=624363 TEST=None Committed: https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2 Cr-Commit-Position: refs/heads/master@{#438183}

Patch Set 1 #

Total comments: 10

Patch Set 2 : retain-autorelease #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -41 lines) Patch
M ios/chrome/browser/infobars/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/infobars/confirm_infobar_controller.mm View 2 chunks +10 lines, -6 lines 0 comments Download
M ios/chrome/browser/infobars/infobar.mm View 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/infobars/infobar_container_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_container_view.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.h View 2 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.mm View 3 chunks +8 lines, -5 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_manager_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_utils.mm View 1 chunk +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm View 1 3 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/native_app_launcher/native_app_infobar_delegate.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/passwords/update_password_infobar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/update_password_infobar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/after_translate_infobar_controller.mm View 1 3 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/translate/before_translate_infobar_controller.mm View 1 3 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/translate/never_translate_infobar_controller.mm View 1 3 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/translate/translate_message_infobar_controller.mm View 1 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
stkhapugin
PTAL
4 years ago (2016-12-12 19:04:14 UTC) #6
noyau (Ping after 24h)
https://codereview.chromium.org/2574463002/diff/1/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm File ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm (right): https://codereview.chromium.org/2574463002/diff/1/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm#newcode100 ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm:100: return infoBarView; This file is not arc, I believe ...
4 years ago (2016-12-13 12:13:12 UTC) #9
stkhapugin
PTAL https://codereview.chromium.org/2574463002/diff/1/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm File ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm (right): https://codereview.chromium.org/2574463002/diff/1/ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm#newcode100 ios/chrome/browser/native_app_launcher/native_app_infobar_controller.mm:100: return infoBarView; On 2016/12/13 12:13:12, noyau wrote: > ...
4 years ago (2016-12-13 13:53:20 UTC) #10
noyau (Ping after 24h)
lgtm
4 years ago (2016-12-13 15:02:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574463002/20001
4 years ago (2016-12-13 15:08:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 16:06:01 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 16:09:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1430a0933113c948217272e05cc24691c86f3da2
Cr-Commit-Position: refs/heads/master@{#438183}

Powered by Google App Engine
This is Rietveld 408576698