ios/chrome/browser/translate/before_translate_infobar_controller.mm - Issue 2574463002: [ObjC ARC] Converts ios/chrome/browser/infobars:infobars to ARC.\n\nAutomatically generated ARCMigr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/translate/before_translate_infobar_controller.mm

Issue 2574463002: [ObjC ARC] Converts ios/chrome/browser/infobars:infobars to ARC.\n\nAutomatically generated ARCMigr… (Closed)

Patch Set: retain-autorelease Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/translate/after_translate_infobar_controller.mm ('k') | ios/chrome/browser/translate/never_translate_infobar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/translate/before_translate_infobar_controller.mm

diff --git a/ios/chrome/browser/translate/before_translate_infobar_controller.mm b/ios/chrome/browser/translate/before_translate_infobar_controller.mm

index 781e0b53f5346a14195c4870aa7e9e801b18c55a..d9624865b5da2480bd702b2ea55dc2f9762a5403 100644

--- a/ios/chrome/browser/translate/before_translate_infobar_controller.mm

+++ b/ios/chrome/browser/translate/before_translate_infobar_controller.mm

@@ -8,6 +8,7 @@

#import <UIKit/UIKit.h>

#include "base/logging.h"

+#include "base/mac/scoped_nsobject.h"

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

#include "components/strings/grit/components_strings.h"

@@ -127,9 +128,9 @@ NSTimeInterval kPickerAnimationDurationInSeconds = 0.2;

#pragma mark -

#pragma mark InfoBarControllerProtocol

-- (base::scoped_nsobject<UIView<InfoBarViewProtocol>>)

- viewForDelegate:(infobars::InfoBarDelegate*)delegate

- frame:(CGRect)frame {

+- (UIView<InfoBarViewProtocol>*)viewForDelegate:

+ (infobars::InfoBarDelegate*)delegate

+ frame:(CGRect)frame {

base::scoped_nsobject<UIView<InfoBarViewProtocol>> infoBarView;

_translateInfoBarDelegate = delegate->AsTranslateInfoBarDelegate();

infoBarView.reset(

@@ -155,7 +156,7 @@ NSTimeInterval kPickerAnimationDurationInSeconds = 0.2;

tag2:TranslateInfoBarIOSTag::BEFORE_DENY

target:self

action:@selector(infoBarButtonDidPress:)];

- return infoBarView;

+ return [[infoBarView retain] autorelease];

}

- (void)updateInfobarLabelOnView:(UIView<InfoBarViewProtocol>*)view {