Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2574273002: [wasm][asm.js] Print a deterministic success result by default. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Print a deterministic success result by default. Printing an asm.js success message and timings is useful, but also non-deterministic. Making the message stable unless a flag is passed. This will avoid making it a hassle in the future to create LayoutTests that use asm.js and verify console output. BUG=v8:4203 R=titzer@chromium.org Committed: https://crrev.com/5124589642ba12228dcd66a8cb8c84c986a13f35 Cr-Commit-Position: refs/heads/master@{#41700}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/asmjs/asm-js.cc View 1 2 chunks +16 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bradn
4 years ago (2016-12-14 17:31:38 UTC) #4
titzer
lgtm with nit https://codereview.chromium.org/2574273002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/2574273002/diff/1/src/flag-definitions.h#newcode509 src/flag-definitions.h:509: DEFINE_BOOL(trace_asm_timing, false, "log asm.js timing to ...
4 years ago (2016-12-14 17:33:09 UTC) #5
bradn
https://codereview.chromium.org/2574273002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/2574273002/diff/1/src/flag-definitions.h#newcode509 src/flag-definitions.h:509: DEFINE_BOOL(trace_asm_timing, false, "log asm.js timing to the console") On ...
4 years ago (2016-12-14 17:42:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574273002/20001
4 years ago (2016-12-14 17:42:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 18:12:13 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 18:13:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5124589642ba12228dcd66a8cb8c84c986a13f35
Cr-Commit-Position: refs/heads/master@{#41700}

Powered by Google App Engine
This is Rietveld 408576698