Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: src/asmjs/asm-js.cc

Issue 2574273002: [wasm][asm.js] Print a deterministic success result by default. (Closed)
Patch Set: fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/asmjs/asm-js.cc
diff --git a/src/asmjs/asm-js.cc b/src/asmjs/asm-js.cc
index a30ac674233fa8ec8ed4bb56c3af6c5c75bed4c4..71a88a1ccdeca599de05f3eaef465264ecd87c9e 100644
--- a/src/asmjs/asm-js.cc
+++ b/src/asmjs/asm-js.cc
@@ -210,9 +210,15 @@ MaybeHandle<FixedArray> AsmJs::CompileAsmViaWasm(ParseInfo* info) {
MessageLocation location(info->script(), info->literal()->position(),
info->literal()->position());
char text[100];
- int length = base::OS::SNPrintF(text, arraysize(text),
- "asm->wasm: %0.3f ms, compile: %0.3f ms",
- asm_wasm_time, compile_time);
+ int length;
+ if (FLAG_trace_asm_time) {
+ length =
+ base::OS::SNPrintF(text, arraysize(text),
+ "success, asm->wasm: %0.3f ms, compile: %0.3f ms",
+ asm_wasm_time, compile_time);
+ } else {
+ length = base::OS::SNPrintF(text, arraysize(text), "success");
+ }
DCHECK_NE(-1, length);
USE(length);
Handle<String> stext(info->isolate()->factory()->InternalizeUtf8String(text));
@@ -307,9 +313,13 @@ MaybeHandle<Object> AsmJs::InstantiateAsmWasm(i::Isolate* isolate,
}
MessageLocation location(script, position, position);
char text[50];
- int length =
- base::OS::SNPrintF(text, arraysize(text), "%0.3f ms",
- instantiate_timer.Elapsed().InMillisecondsF());
+ int length;
+ if (FLAG_trace_asm_time) {
+ length = base::OS::SNPrintF(text, arraysize(text), "success, %0.3f ms",
+ instantiate_timer.Elapsed().InMillisecondsF());
+ } else {
+ length = base::OS::SNPrintF(text, arraysize(text), "success");
+ }
DCHECK_NE(-1, length);
USE(length);
Handle<String> stext(isolate->factory()->InternalizeUtf8String(text));
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698