Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 2574063002: Made -webkit-box-direction property independent. (Closed)

Created:
4 years ago by sashab
Modified:
4 years ago
Reviewers:
napper, rjwright
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made -webkit-box-direction property independent. Made -webkit-box-direction property independent. Also updated independent-inheritance-fast-path.html to include webkitBoxDirection. Also updated make_computed_style_base.py to use 'name_for_methods' instead of 'upper_camel_name' so that Webkit is removed from the front of the name when generating method names. Tested using independent-inheritance-fast-path.html. BUG=628043 Committed: https://crrev.com/1198e2d38d4f0d66852a11c6f2453fe067de3296 Cr-Commit-Position: refs/heads/master@{#438746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
sashab
4 years ago (2016-12-14 02:38:44 UTC) #3
napper
lgtm
4 years ago (2016-12-14 05:17:00 UTC) #5
sashab
4 years ago (2016-12-15 03:02:58 UTC) #9
rjwright
On 2016/12/15 03:02:58, sashab wrote: lgtm
4 years ago (2016-12-15 03:07:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2574063002/1
4 years ago (2016-12-15 03:08:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 04:48:20 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-15 04:49:55 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1198e2d38d4f0d66852a11c6f2453fe067de3296
Cr-Commit-Position: refs/heads/master@{#438746}

Powered by Google App Engine
This is Rietveld 408576698