third_party/WebKit/Source/build/scripts/make_computed_style_base.py - Issue 2574063002: Made -webkit-box-direction property independent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2574063002: Made -webkit-box-direction property independent. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

index b88d41328eb3194fe1659a7d2566d996da9eeb33..6bda8f46625533ee1374a55a89fb66d2c5b6b523 100755

--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py

@@ -88,7 +88,7 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):

self._fields = []

for property in self._properties.values():

if property['keyword_only']:

- property_name = property['upper_camel_name']

+ property_name = property['name_for_methods']

if property['name_for_methods']:

property_name = property['name_for_methods']

property_name_lower = property_name[0].lower() + property_name[1:]

@@ -106,7 +106,7 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):

# If the property is independent, add the single-bit sized isInherited flag

# to the list of Fields as well.

if property['independent']:

- field_name_suffix_upper = property['upper_camel_name'] + 'IsInherited'

+ field_name_suffix_upper = property['name_for_methods'] + 'IsInherited'

field_name_suffix_lower = property_name_lower + 'IsInherited'

self._fields.append(Field(

'inherited_flag',