Media: do not lock the screen orientation when a video goes fullscreen on a tablet.

Media: do not lock the screen orientation when a video goes fullscreen on a tablet.

Ignore the feature being enabled if the Android device form factor is a
tablet.

BUG=673862
Committed: https://crrev.com/7ee146401a6467d4aa96ae8f8ae31560eee7aa12
Cr-Commit-Position: refs/heads/master@{#438514}

[mlamouri (slow - plz ping), 2016-12-13 21:38:45]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 21:39:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-12-13 21:41:20]

mlamouri@chromium.org changed reviewers:
+ clamy@chromium.org, tedchoc@chromium.org

[mlamouri (slow - plz ping), 2016-12-13 21:41:21]

tedcho@ PTAL at content/public/android/
clamy@ PTAL at content/browser/

tedchoc@, it's unfortunate that the RESTRICTION flags we have for the tests are
specific to the chrome layer.

[commit-bot: I haz the power, 2016-12-13 22:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:15:23]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Ted C, 2016-12-13 22:50:27]

tedchoc@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Ted C, 2016-12-13 22:50:28]

lgtm

+jbudorick for the restrictions observation.  Doesn't seem like something that
specifically needs to be restricted to chrome/

[jbudorick, 2016-12-13 22:54:51]

On 2016/12/13 22:50:28, Ted C wrote:
> lgtm
> 
> +jbudorick for the restrictions observation.  Doesn't seem like something that
> specifically needs to be restricted to chrome/

No, it doesn't. RESTRICTION_TYPE_TABLET should be usable in anything that
depends on //ui.

[jbudorick, 2016-12-13 22:55:11]

On 2016/12/13 22:54:51, jbudorick wrote:
> On 2016/12/13 22:50:28, Ted C wrote:
> > lgtm
> > 
> > +jbudorick for the restrictions observation.  Doesn't seem like something
that
> > specifically needs to be restricted to chrome/
> 
> No, it doesn't. RESTRICTION_TYPE_TABLET should be usable in anything that
> depends on //ui.

(to clarify: should be, but isn't)

[jbudorick, 2016-12-13 22:59:43]

On 2016/12/13 22:55:11, jbudorick wrote:
> On 2016/12/13 22:54:51, jbudorick wrote:
> > On 2016/12/13 22:50:28, Ted C wrote:
> > > lgtm
> > > 
> > > +jbudorick for the restrictions observation.  Doesn't seem like something
> that
> > > specifically needs to be restricted to chrome/
> > 
> > No, it doesn't. RESTRICTION_TYPE_TABLET should be usable in anything that
> > depends on //ui.
> 
> (to clarify: should be, but isn't)

... filed https://bugs.chromium.org/p/chromium/issues/detail?id=673917

[mlamouri (slow - plz ping), 2016-12-14 12:16:44]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 12:16:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 13:53:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 13:53:19]

Dry run: This issue passed the CQ dry run.

[clamy, 2016-12-14 14:27:15]

Thanks! Lgtm.

[mlamouri (slow - plz ping), 2016-12-14 14:38:12]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-12-14 14:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2573983002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-14 14:38:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 14:43:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481726292701340,
"parent_rev": "d8d1217061b26cbe799621b42d86e6aaf91344d5", "commit_rev":
"e412b8172fe1834696f9d02c1bf6bddca459e449"}

[commit-bot: I haz the power, 2016-12-14 14:43:35]

Description was changed from

==========
Media: do not lock the screen orientation when a video goes fullscreen on a
tablet.

Ignore the feature being enabled if the Android device form factor is a
tablet.

BUG=673862
==========

to

==========
Media: do not lock the screen orientation when a video goes fullscreen on a
tablet.

Ignore the feature being enabled if the Android device form factor is a
tablet.

BUG=673862

Review-Url: https://codereview.chromium.org/2573983002
==========

[commit-bot: I haz the power, 2016-12-14 14:43:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 14:45:37]

Description was changed from

==========
Media: do not lock the screen orientation when a video goes fullscreen on a
tablet.

Ignore the feature being enabled if the Android device form factor is a
tablet.

BUG=673862

Review-Url: https://codereview.chromium.org/2573983002
==========

to

==========
Media: do not lock the screen orientation when a video goes fullscreen on a
tablet.

Ignore the feature being enabled if the Android device form factor is a
tablet.

BUG=673862

Committed: https://crrev.com/7ee146401a6467d4aa96ae8f8ae31560eee7aa12
Cr-Commit-Position: refs/heads/master@{#438514}
==========

[commit-bot: I haz the power, 2016-12-14 14:45:38]

Patchset 2 (id:??) landed as
https://crrev.com/7ee146401a6467d4aa96ae8f8ae31560eee7aa12
Cr-Commit-Position: refs/heads/master@{#438514}