Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java

Issue 2573983002: Media: do not lock the screen orientation when a video goes fullscreen on a tablet. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java b/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java
index a19fe078abfeeef1485b001d3f6fe3078683e4c7..1f9ad5b7e4a4a69afb208a0de579ca7304521a7a 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java
@@ -16,6 +16,7 @@ import org.chromium.content.browser.test.util.JavaScriptUtils;
import org.chromium.content.browser.test.util.UiUtils;
import org.chromium.content.common.ContentSwitches;
import org.chromium.content_shell_apk.ContentShellTestBase;
+import org.chromium.ui.base.DeviceFormFactor;
import java.util.concurrent.Callable;
import java.util.concurrent.TimeoutException;
@@ -104,6 +105,8 @@ public class VideoFullscreenOrientationLockTest extends ContentShellTestBase {
@MediumTest
@Feature({"VideoFullscreenOrientationLock"})
public void testEnterExitFullscreenWithControlsButton() throws Exception {
+ if (DeviceFormFactor.isTablet(getInstrumentation().getContext())) return;
+
// Start playback to guarantee it's properly loaded.
assertTrue(DOMUtils.isMediaPaused(getWebContents(), VIDEO_ID));
DOMUtils.playMedia(getWebContents(), VIDEO_ID);
@@ -128,6 +131,8 @@ public class VideoFullscreenOrientationLockTest extends ContentShellTestBase {
@MediumTest
@Feature({"VideoFullscreenOrientationLock"})
public void testEnterExitFullscreenWithAPI() throws Exception {
+ if (DeviceFormFactor.isTablet(getInstrumentation().getContext())) return;
+
// Start playback to guarantee it's properly loaded.
assertTrue(DOMUtils.isMediaPaused(getWebContents(), VIDEO_ID));
DOMUtils.playMedia(getWebContents(), VIDEO_ID);
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698