VEA unittest: fix TestSimpleEncode crash while decoder fails

VEA unittest: fix TestSimpleEncode crash while decoder fails

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3eb047232f64eeec5cb234614a30734717520e38
Cr-Commit-Position: refs/heads/master@{#438133}

[hywu, 2016-12-13 08:23:26]

Description was changed from

==========
VEA unittest: fix TestSimpleEncode crash while decoder fails

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
==========

to

==========
VEA unittest: fix TestSimpleEncode crash while decoder fails

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hywu1, 2016-12-13 08:27:03]

hywu@chromium.org changed reviewers:
+ henryhsu@chromium.org, hywu@chromium.org, kcwu@chromium.org,
owenlin@chromium.org, posciak@chromium.org, wuchengli@chromium.org

[kcwu, 2016-12-13 08:40:11]

lgtm

[hywu1, 2016-12-13 08:47:40]

The CQ bit was checked by hywu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 08:47:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wuchengli, 2016-12-13 09:18:32]

https://codereview.chromium.org/2573733002/diff/1/media/gpu/video_encode_acce...
File media/gpu/video_encode_accelerator_unittest.cc (right):

https://codereview.chromium.org/2573733002/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:2084: if (wrong_state) {
Can we use if (HasFailure())?
Same for line 2079.

[hywu1, 2016-12-13 09:40:30]

On 2016/12/13 09:18:32, wuchengli wrote:
>
https://codereview.chromium.org/2573733002/diff/1/media/gpu/video_encode_acce...
> File media/gpu/video_encode_accelerator_unittest.cc (right):
> 
>
https://codereview.chromium.org/2573733002/diff/1/media/gpu/video_encode_acce...
> media/gpu/video_encode_accelerator_unittest.cc:2084: if (wrong_state) {
> Can we use if (HasFailure())?
> Same for line 2079.

Done in patch set 2.

[wuchengli, 2016-12-13 10:01:51]

lgtm

[hywu1, 2016-12-13 10:05:31]

The CQ bit was checked by hywu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 10:05:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 11:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 11:16:57]

Dry run: This issue passed the CQ dry run.

[hywu1, 2016-12-13 11:53:28]

The CQ bit was checked by hywu@chromium.org

[hywu1, 2016-12-13 11:53:28]

The patchset sent to the CQ was uploaded after l-g-t-m from kcwu@chromium.org
Link to the patchset: https://codereview.chromium.org/2573733002/#ps20001
(title: "VEA unittest: fix TestSimpleEncode crash while decoder fails")

[commit-bot: I haz the power, 2016-12-13 11:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 11:57:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481630008192950,
"parent_rev": "b2a82fb7b41ff0b678be642977d7ccda105b6af2", "commit_rev":
"7263e1e8c0bbaeeb8ad823d35ded227ca5da5d95"}

[commit-bot: I haz the power, 2016-12-13 11:57:57]

Description was changed from

==========
VEA unittest: fix TestSimpleEncode crash while decoder fails

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
VEA unittest: fix TestSimpleEncode crash while decoder fails

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2573733002
==========

[commit-bot: I haz the power, 2016-12-13 11:57:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 11:59:45]

Description was changed from

==========
VEA unittest: fix TestSimpleEncode crash while decoder fails

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2573733002
==========

to

==========
VEA unittest: fix TestSimpleEncode crash while decoder fails

If VideoFrameQualityValidator cannot get a decoder, the
TestSimpleEncode test would abort without destroying the
encoder first and thus causes a crash. This change makes
the test to fail properly.

BUG=672403
TEST=Run VEA unittest built for external chromium on Kevin.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/3eb047232f64eeec5cb234614a30734717520e38
Cr-Commit-Position: refs/heads/master@{#438133}
==========

[commit-bot: I haz the power, 2016-12-13 11:59:46]

Patchset 2 (id:??) landed as
https://crrev.com/3eb047232f64eeec5cb234614a30734717520e38
Cr-Commit-Position: refs/heads/master@{#438133}