VEA unittest: fix TestSimpleEncode crash while decoder fails

media/gpu/video_encode_accelerator_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <inttypes.h>
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 2056 matching lines @@
   enum ClientState state_transitions[] = {CS_INITIALIZED, CS_ENCODING,
                                           CS_FINISHED, CS_VALIDATED};
 
   // Wait for all encoders to go through all states and finish.
   // Do this by waiting for all encoders to advance to state n before checking
   // state n+1, to verify that they are able to operate concurrently.
   // It also simulates the real-world usage better, as the main thread, on which
   // encoders are created/destroyed, is a single GPU Process ChildThread.
   // Moreover, we can't have proper multithreading on X11, so this could cause
   // hard to debug issues there, if there were multiple "ChildThreads".
+  bool wrong_state = false;
   for (const auto& state : state_transitions) {
-    for (size_t i = 0; i < num_concurrent_encoders; i++)
-      ASSERT_EQ(state, notes[i]->Wait());
+    for (size_t i = 0; i < num_concurrent_encoders && !wrong_state; i++) {
+      ClientState wait_state = notes[i]->Wait();
+      EXPECT_EQ(state, wait_state);
+      wrong_state = (state != wait_state);
+    }
+    if (wrong_state) {

[wuchengli, 2016/12/13 09:18:32]

Can we use if (HasFailure())?
Same for line 2079.

+      break;
+    }
   }
 
   for (size_t i = 0; i < num_concurrent_encoders; ++i) {
     encoder_thread.task_runner()->PostTask(
         FROM_HERE,
         base::Bind(&VEAClient::DestroyEncoder, base::Unretained(clients[i])));
   }
 
   // This ensures all tasks have finished.
   encoder_thread.Stop();
@@ skipping 233 matching lines @@
 
   media::g_env =
       reinterpret_cast<media::VideoEncodeAcceleratorTestEnvironment*>(
           testing::AddGlobalTestEnvironment(
               new media::VideoEncodeAcceleratorTestEnvironment(
                   std::move(test_stream_data), log_path, run_at_fps,
                   needs_encode_latency, verify_all_output)));
 
   return RUN_ALL_TESTS();
 }