Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2573463002: Remove unused ArcUserDataService. (Closed)

Created:
4 years ago by hidehiko
Modified:
4 years ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, dspaid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ArcUserDataService. It used to be used for data/ dir removal, but it is now integrated into ArcSessionManager. Remove the unused class now. BUG=657687 BUG=b/31079732 TEST=Ran bots. Committed: https://crrev.com/b846799719e0e12d5df5853fdd9c436d40c048c5 Cr-Commit-Position: refs/heads/master@{#437983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -174 lines) Patch
M chrome/browser/chromeos/arc/arc_service_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/enterprise/arc_enterprise_reporting_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/arc/user_data/arc_user_data_service.h View 1 chunk +0 lines, -84 lines 0 comments Download
D components/arc/user_data/arc_user_data_service.cc View 1 chunk +0 lines, -86 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
hidehiko
PTAL.
4 years ago (2016-12-12 15:22:54 UTC) #4
Luis Héctor Chávez
lgtm
4 years ago (2016-12-12 17:16:08 UTC) #5
hidehiko
Thank you for review. Submitting. Note that trybot failure looks unrelated and/or just flaky to ...
4 years ago (2016-12-12 17:35:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573463002/1
4 years ago (2016-12-12 17:36:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197274)
4 years ago (2016-12-12 20:35:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573463002/1
4 years ago (2016-12-12 22:49:08 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 01:59:35 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-13 02:02:26 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b846799719e0e12d5df5853fdd9c436d40c048c5
Cr-Commit-Position: refs/heads/master@{#437983}

Powered by Google App Engine
This is Rietveld 408576698