Migrate ArcBridgeService::Observer and ArcSession::Observer.

Migrate ArcBridgeService::Observer and ArcSession::Observer.

Both are conceptually same. So merge them into ArcSessionObserver.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Committed: https://crrev.com/9bc9ba5d39432da1cf6ab12bd8ab5146004fbcc5
Cr-Commit-Position: refs/heads/master@{#438467}

[hidehiko, 2016-12-12 17:43:22]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 17:43:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-12-12 17:44:07]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-12-12 17:44:08]

PTAL.

[hidehiko, 2016-12-12 17:44:37]

On 2016/12/12 17:44:08, hidehiko wrote:
> PTAL.

Note: this is preparation to move ArcSession related stuff from ArcBridgeService
into ArcSessionManager.

[commit-bot: I haz the power, 2016-12-12 17:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 17:56:59]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[hidehiko, 2016-12-12 18:07:22]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 18:07:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:00:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hidehiko, 2016-12-13 08:25:56]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 08:26:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 09:18:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 09:18:25]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2016-12-13 17:44:50]

Rebased. Friendly ping?

[Luis Héctor Chávez, 2016-12-13 18:02:55]

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
File components/arc/arc_session_observer.h (right):

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
components/arc/arc_session_observer.h:12: // Interface to observe the ARC
container running state.
This file has "ARC container", "ArcSession", and "ARC instance". Let's
standardize on one. Historically it was "ARC instance", but I'm not opposed to
change to any of the other ones, as long as we're consistent about it.

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
components/arc/arc_session_observer.h:15: // Describes the reason the bridge is
stopped.
nit: s/bridge/ARC xxx/ (for whatever xxx we standardize on).

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
components/arc/arc_session_observer.h:35: virtual void OnReady() {}
How about OnSessionReady / OnSessionStopped? We use the same pattern with the
InstanceHolder, and it'll avoid naming collisions.

[hidehiko, 2016-12-14 01:23:24]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[hidehiko, 2016-12-14 01:23:33]

Thank you for review. PTAL.

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
File components/arc/arc_session_observer.h (right):

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
components/arc/arc_session_observer.h:12: // Interface to observe the ARC
container running state.
On 2016/12/13 18:02:54, Luis Héctor Chávez wrote:
> This file has "ARC container", "ArcSession", and "ARC instance". Let's
> standardize on one. Historically it was "ARC instance", but I'm not opposed to
> change to any of the other ones, as long as we're consistent about it.

Let's use ARC instance, then. According to git grep, it is commonly used.
I'm tempted to use ArcSession, to be consistent with the class name, but IMHO
it's fine at least for now.

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
components/arc/arc_session_observer.h:15: // Describes the reason the bridge is
stopped.
On 2016/12/13 18:02:54, Luis Héctor Chávez wrote:
> nit: s/bridge/ARC xxx/ (for whatever xxx we standardize on).

Done.

https://codereview.chromium.org/2567083002/diff/40001/components/arc/arc_sess...
components/arc/arc_session_observer.h:35: virtual void OnReady() {}
On 2016/12/13 18:02:54, Luis Héctor Chávez wrote:
> How about OnSessionReady / OnSessionStopped? We use the same pattern with the
> InstanceHolder, and it'll avoid naming collisions.

Done.

[commit-bot: I haz the power, 2016-12-14 01:24:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 02:26:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 02:26:22]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-12-14 04:04:45]

lgtm

[hidehiko, 2016-12-14 04:46:57]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2016-12-14 04:47:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 04:55:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 04:55:07]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hidehiko, 2016-12-14 07:44:22]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2016-12-14 07:44:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2567083002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-14 07:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 09:01:23]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481701462659800,
"parent_rev": "1e9b95c033affb518d934af3a852a3bcaaf91891", "commit_rev":
"200f446be758e1357223ef663996765f9663f958"}

[commit-bot: I haz the power, 2016-12-14 09:02:28]

Description was changed from

==========
Migrate ArcBridgeService::Observer and ArcSession::Observer.

Both are conceptually same. So merge them into ArcSessionObserver.

BUG=657687
BUG=b/31079732
TEST=Ran bots.
==========

to

==========
Migrate ArcBridgeService::Observer and ArcSession::Observer.

Both are conceptually same. So merge them into ArcSessionObserver.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2567083002
==========

[commit-bot: I haz the power, 2016-12-14 09:02:29]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-14 09:04:25]

Description was changed from

==========
Migrate ArcBridgeService::Observer and ArcSession::Observer.

Both are conceptually same. So merge them into ArcSessionObserver.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2567083002
==========

to

==========
Migrate ArcBridgeService::Observer and ArcSession::Observer.

Both are conceptually same. So merge them into ArcSessionObserver.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Committed: https://crrev.com/9bc9ba5d39432da1cf6ab12bd8ab5146004fbcc5
Cr-Commit-Position: refs/heads/master@{#438467}
==========

[commit-bot: I haz the power, 2016-12-14 09:04:26]

Patchset 5 (id:??) landed as
https://crrev.com/9bc9ba5d39432da1cf6ab12bd8ab5146004fbcc5
Cr-Commit-Position: refs/heads/master@{#438467}