Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/extensions/extension_tab_util.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_util.h
diff --git a/chrome/browser/extensions/extension_tab_util.h b/chrome/browser/extensions/extension_tab_util.h
index bbf042becab605f75203072f52d9de5610ddcdff..b997aa3d48dc78975e6d895360bf7f5db64e8c84 100644
--- a/chrome/browser/extensions/extension_tab_util.h
+++ b/chrome/browser/extensions/extension_tab_util.h
@@ -12,7 +12,7 @@
#include "ui/base/window_open_disposition.h"
class Browser;
-class ChromeAsyncExtensionFunction;
+class ChromeUIThreadExtensionFunction;
class GURL;
class Profile;
class TabStripModel;
@@ -53,9 +53,10 @@ class ExtensionTabUtil {
// Opens a new tab given an extension function |function| and creation
// parameters |params|. Returns a Tab object if successful, or NULL and
// optionally sets |error| if an error occurs.
- static base::DictionaryValue* OpenTab(ChromeAsyncExtensionFunction* function,
- const OpenTabParams& params,
- std::string* error);
+ static base::DictionaryValue* OpenTab(
+ ChromeUIThreadExtensionFunction* function,
+ const OpenTabParams& params,
+ std::string* error);
static int GetWindowId(const Browser* browser);
static int GetWindowIdOfTabStripModel(const TabStripModel* tab_strip_model);
@@ -64,9 +65,10 @@ class ExtensionTabUtil {
static int GetWindowIdOfTab(const content::WebContents* web_contents);
static base::ListValue* CreateTabList(const Browser* browser,
const Extension* extension);
- static Browser* GetBrowserFromWindowID(ChromeAsyncExtensionFunction* function,
- int window_id,
- std::string* error_message);
+ static Browser* GetBrowserFromWindowID(
+ ChromeUIThreadExtensionFunction* function,
+ int window_id,
+ std::string* error_message);
// Creates a Tab object (see chrome/common/extensions/api/tabs.json) with
// information about the state of a browser tab. Depending on the
« no previous file with comments | « chrome/browser/extensions/extension_function_test_utils.cc ('k') | chrome/browser/extensions/extension_tab_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698